Fix #13751 (cmdlineparser: --file-filter matching of looked up files in provided paths)#7517
Merged
danmar merged 3 commits intocppcheck-opensource:mainfrom May 12, 2025
Merged
Conversation
danmar
changed the title
danmar
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #13751 by improving the matching of files in provided paths when using the --file-filter option. Key changes include:
- Adding new tests to verify file filtering behavior with simplified paths and case differences.
- Extending the matchglob and matchglobs functions to support a caseInsensitive parameter.
- Updating the CmdLineParser to use the new filtering logic.
- Updating the releasenotes accordingly.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/testcmdlineparser.cpp | Added new test cases for file filter matching behavior. |
| releasenotes.txt | Documented the fix for improved --file-filter matching. |
| lib/utils.h | Updated function declarations for matchglob(s) to add case handling. |
| lib/utils.cpp | Implemented caseInsensitive comparison in matchglob(s). |
| cli/cmdlineparser.h | Declared a new filterFiles function. |
| cli/cmdlineparser.cpp | Refactored file filtering logic to use filterFiles. |
| const std::vector<std::string> fileFilters{"m1.c"}; | ||
| const std::list<FileWithDetails> filesResolved{ FileWithDetails("M1.C", Standards::Language::C, 123) }; | ||
| const std::list<FileWithDetails> files = CmdLineParser::filterFiles(fileFilters, filesResolved); | ||
| #ifdef _WIN32 |
There was a problem hiding this comment.
[nitpick] Consider adding a comment clarifying that the test expects case-insensitive filtering only on Windows to aid maintainability and clarity of the platform-specific behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.