Skip to content

CMake cleanup #7658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 28 commits into from
Nov 5, 2025
Merged

CMake cleanup #7658

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
a72f0e8
CMake cleanup
pfultz2 Jul 9, 2025
7536500
Add missing cmake file
pfultz2 Jul 9, 2025
9524828
Fix cmake
pfultz2 Jul 9, 2025
aae3fa0
Consistent link libraries
pfultz2 Jul 9, 2025
e5f8f8c
Use object library
pfultz2 Jul 9, 2025
599a54e
Use targets
pfultz2 Jul 9, 2025
74f853f
Remove const to fix cast
pfultz2 Jul 9, 2025
91afb23
Remove noreturn
pfultz2 Jul 9, 2025
00c462a
Fix pcre linking
pfultz2 Jul 9, 2025
0e7f402
Add frontend
pfultz2 Jul 9, 2025
ca5c192
Remove SYSTEM
pfultz2 Jul 9, 2025
be40581
Disable precompile headers for now
pfultz2 Jul 9, 2025
e690613
Remove OBJECT
pfultz2 Jul 10, 2025
151d3d0
Use target_external_include_directories
pfultz2 Jul 10, 2025
0276fd8
Update target name
pfultz2 Jul 10, 2025
25d8719
Add verbose flag
pfultz2 Jul 10, 2025
f95486d
Remove interface library
pfultz2 Jul 10, 2025
5416baa
Make cli available for dmake
pfultz2 Jul 10, 2025
063a2f8
Fix issues with building with cli disabled
pfultz2 Jul 10, 2025
5a27cca
Remove verbose flag
pfultz2 Jul 11, 2025
a4b579d
Remove foreach loop
pfultz2 Jul 11, 2025
c645209
Merge branch 'main' into cmake-cleanup
pfultz2 Aug 11, 2025
b8bd740
Merge
pfultz2 Sep 18, 2025
f211acd
Add back const
pfultz2 Sep 18, 2025
5c47f9e
Remove line
pfultz2 Sep 18, 2025
8193d33
Merge branch 'main' into cmake-cleanup
pfultz2 Oct 5, 2025
56c3699
Merge
pfultz2 Oct 28, 2025
872f922
Remove duplicate line
pfultz2 Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,6 @@ if (Boost_FOUND)
target_include_directories(cppcheck-core-private SYSTEM PRIVATE ${Boost_INCLUDE_DIRS})
endif()

if (NOT CMAKE_DISABLE_PRECOMPILE_HEADERS)
target_precompile_headers(cppcheck-core-private PRIVATE precompiled.h)
endif()
# if (NOT CMAKE_DISABLE_PRECOMPILE_HEADERS)
# target_precompile_headers(cppcheck-core-private PRIVATE precompiled.h)
# endif()
Copy link
Copy Markdown
Collaborator

@firewave firewave Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be enabled again before merging.

Copy link
Copy Markdown
Contributor Author

@pfultz2 pfultz2 Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, that was to test the CI. I was getting error:

../../../lib/CMakeFiles/cppcheck-core-private.dir/cmake_pch.hxx.gch: file not recognized: file format not recognized

Now with it disabled I get an error that there isnt a make rule for it.

Copy link
Copy Markdown
Contributor Author

@pfultz2 pfultz2 Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, you are explicitly building it in selfcheck, but its using the wrong target name.

Copy link
Copy Markdown
Contributor Author

@pfultz2 pfultz2 Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching to the OBJECT library directly fixed this issue.

Loading