Skip to content

tests: increase coverage for commaSeparatedReturn (negative case) [#13869] #7746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aryanrahar wants to merge 6 commits into from
Closed

tests: increase coverage for commaSeparatedReturn (negative case) [#13869] #7746

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4e73985
tests: add regression guards for containerOutOfBounds on non-empty co…
aryanrahar Aug 12, 2025
ab6ebb6
tests: increase containerOutOfBounds coverage for non-empty containers
aryanrahar Aug 13, 2025
7036b2c
correction of identation
aryanrahar Aug 13, 2025
a5af661
tests(other): add negative coverage for commaSeparatedReturn (no comm…
aryanrahar Aug 16, 2025
e6d84cf
tests(other): format with uncrustify
aryanrahar Aug 23, 2025
6bca6ac
tests(other): increase coverage for commaSeparatedReturn (negative ca…
aryanrahar Aug 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions test/teststl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@ class TestStl : public TestFixture {

TEST_CASE(checkKnownEmptyContainer);
TEST_CASE(checkMutexes);
TEST_CASE(commaSeparatedReturn_no_fp);
Copy link
Copy Markdown
Collaborator

@danmar danmar Aug 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems misplaced where are our other commaSeparatedReturn tests?

my hope is that if we put related tests together it's possible to see overlaps and gaps ..

}

struct CheckOptions
Expand Down Expand Up @@ -7201,6 +7202,17 @@ class TestStl : public TestFixture {
"}\n");
ASSERT_EQUALS("", errout_str());
}
void commaSeparatedReturn_no_fp()
Copy link
Copy Markdown
Collaborator

@danmar danmar Aug 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this code is not formatted properly. Either run the runformat script or there is a diff from the "format" action that you can download and apply.

{
check(
"int g(){\n"
" int a = 0, b = 1;\n"
" a = (a, b); // comma operator in an assignment, not in return\n"
" return a; // plain return, should not trigger\n"
"}\n"
);
ASSERT_EQUALS("", errout_str());
}
};

REGISTER_TEST(TestStl)
Loading