Skip to content

Fix #13645 (fail to load platform when executing Cppcheck in PATH) #7977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmar merged 9 commits into from
Nov 27, 2025
Merged

Fix #13645 (fail to load platform when executing Cppcheck in PATH) #7977

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2aaac23
Fix #13645 (fail to load platform when executing Cppcheck in PATH)
danmar Nov 20, 2025
8f41554
fix
danmar Nov 20, 2025
146046e
test
danmar Nov 20, 2025
62f21bc
test
danmar Nov 21, 2025
85e352c
format_path
danmar Nov 21, 2025
3e0b256
lib+platform
danmar Nov 21, 2025
4bc9b2c
add addon test
danmar Nov 21, 2025
73aa896
config
danmar Nov 21, 2025
04e15e3
cleanup
danmar Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/cmdlineparser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ CmdLineParser::Result CmdLineParser::parseFromArgs(int argc, const char* const a

std::vector<std::string> lookupPaths{
Path::getCurrentPath(), // TODO: do we want to look in CWD?
Path::getPathFromFilename(argv[0])
Path::getPathFromFilename(mSettings.exename),
};

bool executorAuto = true;
Expand Down
22 changes: 22 additions & 0 deletions test/cli/lookup_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,28 @@ def test_platform_lookup_ext(tmpdir):
]


def test_platform_lookup_path(tmpdir):
Comment thread
danmar marked this conversation as resolved.
test_file = os.path.join(tmpdir, 'test.c')
with open(test_file, 'wt'):
pass

c = 'cppcheck.exe' if sys.platform == 'win32' else 'cppcheck'
Comment thread
danmar marked this conversation as resolved.
Outdated
path = os.path.dirname(__lookup_cppcheck_exe())
env = os.environ.copy()
env['PATH'] = path
exitcode, stdout, stderr, _ = cppcheck_ex(args=['--debug-lookup=platform', '--platform=avr8.xml', test_file], cppcheck_exe=c, cwd=str(tmpdir), env=env)
assert exitcode == 0, stdout if stdout else stderr
lines = stdout.replace('\\', '/').splitlines()
assert lines == [
"looking for platform 'avr8.xml'",
"try to load platform file '{}/avr8.xml' ... Error=XML_ERROR_FILE_NOT_FOUND ErrorID=3 (0x3) Line number=0: filename={}/avr8.xml".format(tmpdir, tmpdir),
"try to load platform file '{}/platforms/avr8.xml' ... Error=XML_ERROR_FILE_NOT_FOUND ErrorID=3 (0x3) Line number=0: filename={}/platforms/avr8.xml".format(tmpdir, tmpdir),
"try to load platform file '{}/avr8.xml' ... Error=XML_ERROR_FILE_NOT_FOUND ErrorID=3 (0x3) Line number=0: filename={}/avr8.xml".format(path, path),
"try to load platform file '{}/platforms/avr8.xml' ... Success".format(path),
'Checking {} ...'.format(test_file)
]


def test_platform_lookup_notfound(tmpdir):
test_file = os.path.join(tmpdir, 'test.c')
with open(test_file, 'wt'):
Expand Down
Loading