Skip to content

Fix #14428 FP duplicateCondition, pointer data may be changed in function call #8155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 4 commits into from
Feb 10, 2026
Merged

Fix #14428 FP duplicateCondition, pointer data may be changed in function call #8155

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c809367
Update astutils.cpp
chrchr-github Jan 26, 2026
27cad48
Update testcondition.cpp
chrchr-github Jan 26, 2026
e996637
Update testcondition.cpp
chrchr-github Feb 10, 2026
eddc873
Update testcondition.cpp
chrchr-github Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions lib/astutils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3091,8 +3091,6 @@ static const Token* findExpressionChangedImpl(const Token* expr,
}
bool global = false;
if (tok->variable()) {
if (tok->variable()->isConst())
return false;
global = !tok->variable()->isLocal() && !tok->variable()->isArgument() &&
!(tok->variable()->isMember() && !tok->variable()->isStatic());
} else if (tok->isIncompleteVar() && !tok->isIncompleteConstant()) {
Expand Down
11 changes: 11 additions & 0 deletions test/testcondition.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5882,6 +5882,17 @@ class TestCondition : public TestFixture {
" if (strlen(s2) > 0) {}\n"
"}\n");
ASSERT_EQUALS("", errout_str());

check("void g(int*);\n" // #14428
Comment thread
chrchr-github marked this conversation as resolved.
"int f(int* const p) {\n"
" int i = 0;\n"
" if (*p == 0)\n"
" g(p);\n"
" if (*p == 0)\n"
" i = 1;\n"
" return i;\n"
"}\n");
ASSERT_EQUALS("", errout_str());
}

void checkInvalidTestForOverflow() {
Expand Down
Loading