Skip to content

Fix #14559 FN constVariablePointer (ternary expression passed to unknown function, regression) #8331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 3 commits into from
Mar 28, 2026
Merged

Fix #14559 FN constVariablePointer (ternary expression passed to unknown function, regression) #8331

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d75f8dc
Update astutils.cpp
chrchr-github Mar 12, 2026
1e05778
Update testother.cpp
chrchr-github Mar 12, 2026
273cfbd
Merge branch 'main' into chr_14559
chrchr-github Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/astutils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2628,7 +2628,7 @@ bool isVariableChanged(const Token *tok, int indirect, const Settings &settings,
if (!tok->isMutableExpr())
return false;

if (indirect == 0 && isConstVarExpression(tok))
if (isConstVarExpression(tok))
return false;

const Token *tok2 = tok;
Expand Down Expand Up @@ -3369,7 +3369,7 @@ bool isConstVarExpression(const Token *tok, const std::function<bool(const Token
if (!tok)
return false;
if (tok->str() == "?" && tok->astOperand2() && tok->astOperand2()->str() == ":") // ternary operator
return isConstVarExpression(tok->astOperand2()->astOperand1()) && isConstVarExpression(tok->astOperand2()->astOperand2()); // left and right of ":"
return isConstVarExpression(tok->astOperand2()->astOperand1()) || isConstVarExpression(tok->astOperand2()->astOperand2()); // left and right of ":"
Comment thread
danmar marked this conversation as resolved.
if (skipPredicate && skipPredicate(tok))
return false;
if (Token::simpleMatch(tok->previous(), "sizeof ("))
Expand Down
12 changes: 12 additions & 0 deletions test/testother.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4763,6 +4763,18 @@ class TestOther : public TestFixture {
" return [](int* p) { return *p; }(&i);\n"
"}\n");
ASSERT_EQUALS("[test.cpp:3:20]: (style) Parameter 'p' can be declared as pointer to const [constParameterPointer]\n", errout_str());

check("struct S {\n" // #14559
" int gc() const;\n"
" int gnc();\n"
"};\n"
"int f1(S* s) {\n"
" return h(s ? s->gc() : 1);\n"
"}\n"
"int f2(S* s) {\n"
" return h(s ? s->gnc() : 1);\n"
"}\n");
ASSERT_EQUALS("[test.cpp:5:11]: (style) Parameter 's' can be declared as pointer to const [constParameterPointer]\n", errout_str());
}

void constArray() {
Expand Down
Loading