TestCmdlineParser: resolved bogus TODO asserts

[firewave]

No description provided.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[chrchr-github]

So we don't ever want to support --suppress=uninitvar,noConstructor? Intuitively, that's how I would expect this option to work...

[firewave]

It takes a single suppression line. Just using the ID is working because all other fields are optional in that format. So it is different from --enable.

[chrchr-github]

It takes a single suppression line. Just using the ID is working because all other fields are optional in that format. So it is different from --enable.

You mean we would have to support --suppress=uninitvar:abc.cpp:123,noConstructor:def.cpp:456 as well?

[firewave]

You mean we would have to support --suppress=uninitvar:abc.cpp:123,noConstructor:def.cpp:456 as well?

That would be implied. We could just split it by ,. But as this hasn't been supported in probably more than a decade and no feature request for this coming up so far (as far as I can tell). I do not see any reason to support it. You cannot specify more than one suppression per line in a file either so it would be consistent.