Skip to content

Refs #13814 FP compareValueOutOfTypeRangeError with INT_MAX #8483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 3 commits into from
Apr 25, 2026
+10 −1
Merged

Refs #13814 FP compareValueOutOfTypeRangeError with INT_MAX #8483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0bf6bc
Update checkcondition.cpp
chrchr-github Apr 23, 2026
93ca67e
Update testcondition.cpp
chrchr-github Apr 23, 2026
590df8a
Update std.c
chrchr-github Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/checkcondition.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1970,6 +1970,8 @@ void CheckCondition::checkCompareValueOutOfTypeRange()
continue;
if (valueTok->getKnownIntValue() < 0 && valueTok->valueType() && valueTok->valueType()->sign != ValueType::Sign::SIGNED)
continue;
if (typeTok->isLiteral())
continue;
std::uint8_t bits = 0;
switch (typeTok->valueType()->type) {
case ValueType::Type::BOOL:
Expand Down
2 changes: 1 addition & 1 deletion test/cfg/std.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ void test_int32_min() {
}

void test_int64_min() {
// cppcheck-suppress compareValueOutOfTypeRangeError ; tests that INT64_MIN is a signed expression
// TODO cppcheck-suppress knownConditionTrueFalse // #13814
if (INT64_MIN < 0) {}
}

Expand Down
7 changes: 7 additions & 0 deletions test/testcondition.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6375,6 +6375,13 @@ class TestCondition : public TestFixture {
ASSERT_EQUALS("[test.cpp:3:14]: (style) Comparing expression of type 'const unsigned int &' against value 4294967295. Condition is always true. [compareValueOutOfTypeRangeError]\n"
"[test.cpp:4:13]: (style) Comparing expression of type 'const unsigned int &' against value 4294967295. Condition is always false. [compareValueOutOfTypeRangeError]\n",
errout_str());

check("void f() {\n"
" long long ll = 1024 * 1024 * 1024;\n"
" if (ll * 8 < INT_MAX) {}\n"
" if (INT_MAX > ll * 8) {}\n"
"}\n");
ASSERT_EQUALS("", errout_str());
}

void knownConditionCast() {
Expand Down
Loading