chore: simplify run-tests by using text mode for subprocess

Author: jcfr

run-tests.py

@@ -9,7 +9,7 @@
 
 def cleanup(out: str) -> str:
   parts = []
-  for line in out.decode('utf-8').splitlines():
+  for line in out.splitlines():
     if len(line) > 1 and line[0] == '#':
       continue
     parts.append("".join(line.split()))
@@ -99,7 +99,7 @@ def run(compiler_executable: str, compiler_args: list[str]) -> tuple[int, str, s
   cmd = [compiler_executable, *compiler_args]
 
   try:
-    with subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE) as process:
+    with subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, text=True, encoding="utf-8") as process:
       stdout, stderr = process.communicate()
       exit_code = process.returncode
   except FileNotFoundError as e:
@@ -108,8 +108,8 @@ def run(compiler_executable: str, compiler_args: list[str]) -> tuple[int, str, s
   except Exception as e:
     return (1, "", f"{e}")
 
-  output = cleanup(stdout)  # bytes -> str via cleanup
-  error = (stderr or b"").decode("utf-8", errors="replace").strip()
+  output = cleanup(stdout)
+  error = (stderr or "").strip()
   return (exit_code, output, error)