fixed #14619/#14620 - fixed potential memory leak using --rule / suppressed valgrind false positive (danmar#8365)

Author: firewave

.github/workflows/asan.yml

@@ -23,7 +23,6 @@ jobs:
     env:
       QT_VERSION: 6.10.0
       ASAN_OPTIONS: detect_stack_use_after_return=1
-      LSAN_OPTIONS: suppressions=lsan-suppr.txt:print_suppressions=0
       # TODO: figure out why there are cache misses with PCH enabled
       CCACHE_SLOPPINESS: pch_defines,time_macros
 
@@ -100,7 +99,6 @@ jobs:
 
       - name: Run CTest
         run: |
-          cp lsan-suppr.txt cmake.output/bin
           ctest --test-dir cmake.output --output-on-failure -j$(nproc)
 
       - name: Run test/cli

.github/workflows/valgrind.yml

@@ -51,7 +51,7 @@ jobs:
       - name: Run valgrind
         run: |
           ec=0
-          valgrind --error-limit=yes --leak-check=full --num-callers=50 --show-reachable=yes --track-origins=yes --suppressions=valgrind/testrunner.supp --gen-suppressions=all --log-fd=9 --error-exitcode=42 ./testrunner TestGarbage TestOther TestSimplifyTemplate 9>memcheck.log || ec=1
+          valgrind --error-limit=yes --leak-check=full --num-callers=50 --show-reachable=yes --track-origins=yes --suppressions=valgrind/testrunner.supp --gen-suppressions=all -s --log-fd=9 --error-exitcode=42 ./testrunner TestGarbage TestOther TestSimplifyTemplate TestRegEx 9>memcheck.log || ec=1
           cat memcheck.log
           exit $ec
         # TODO: debuginfod.ubuntu.com is currently not responding to any requests causing it to run into a 40(!) minute timeout

lib/regex.cpp

@@ -167,7 +167,7 @@ namespace {
         ~PcreRegex() override
         {
             if (mExtra) {
-                pcre_free(mExtra);
+                pcre_free_study(mExtra);
                 mExtra = nullptr;
             }
             if (mRe) {

lsan-suppr.txt

@@ -14,3 +14,9 @@
    obj:*
    obj:*
 }
+{
+   TestRegEx::partialmatch false positive
+   Memcheck:Cond
+   obj:*
+   obj:*
+}