fix/ #53 changed syntax for executing commands through argument setting (#57)

* fix/ #53 changed syntax for executing commands through argument setting

* removed console log

* clean up in readme

Author: davidramnero

README.md

@@ -10,7 +10,7 @@
 - **Diagnostic cleanup**: When you close a file, its diagnostics are automatically cleared.
 - **Project file support**: You can feed your project file to cppcheck through the `--project` flag in the `cppcheck-official.arguments` field in the extension settings.
 - **Warning notes**: Display notes for warnings when those are available
-- **Dynamic config**: The extension supports running a script to generate arguments to pass to cppcheck. This can be done by including the command in the argument field wrapped with \${}, e.g. `--suppress=memleak:src/file1.cpp ${bash path/to/script.sh}`. The script is expected to output the argument(s) wrapped with \${}. If the script e.g. creates a project file it should print out as `${--project=path/to/projectfile.json}`. This output will be spliced into the argument string as such: `--suppress=memleak:src/file1.cpp --project=path/to/projectfile.json`.
+- **Dynamic config**: The extension supports running a script to generate arguments to pass to cppcheck. This can be done by including the command in the argument field wrapped with \@(), e.g. `--suppress=memleak:src/file1.cpp @(bash path/to/script.sh)`. The script is expected to output the argument(s) wrapped with \@(). If the script e.g. creates a project file it should print out as `@(--project=path/to/projectfile.json)`. This output will be spliced into the argument string as such: `--suppress=memleak:src/file1.cpp --project=path/to/projectfile.json`.
 ## Requirements
 
  **Cppcheck** must be installed on your system.

src/extension.ts

@@ -94,12 +94,12 @@ export async function activate(context: vscode.ExtensionContext) {
         var  args = config.get<string>("cppcheck-official.arguments", "");
         var processedArgs = '';
         // If argument field contains command to run script we do so here
-        if (args.includes('${')) {
-            const scriptCommand = args.split("${")[1].split("}")[0];
+        if (args.includes('@(')) {
+            const scriptCommand = args.split("@(")[1].split(")")[0];
             const scriptOutput = await runCommand(scriptCommand);
             // We expect that the script output that is to be used as arguments will be wrapped with ${}
-            const scriptOutputTrimmed = scriptOutput.split("${")[1].split("}")[0];
-            processedArgs = args.split("${")[0] + scriptOutputTrimmed + args.split("}")?.[1];
+            const scriptOutputTrimmed = scriptOutput.split("@(")[1].split(")")[0];
+            processedArgs = args.split("@(")[0] + scriptOutputTrimmed + args.split(")")?.[1];
         } else {
             processedArgs = args;
         }