Make it possible to run ruisapp both as console and GUI app.#22
Merged
Conversation
igagis
reviewed
Jun 4, 2025
| return 0; | ||
| } | ||
|
|
||
| int main(int argc, char** argv) |
Member
There was a problem hiding this comment.
I think here you can mark the argv argument as const char** and then no need to cast
igagis
reviewed
Jun 4, 2025
| { | ||
| // TODO: pass argc and argv | ||
| ruisapp::winmain(0, nullptr); | ||
| ruisapp::winmain(__argc, (const char**)__argv); |
Member
There was a problem hiding this comment.
Could you use C++-style cast and avoid using C-style cast here? I don't know what is the type of that__argv, if it is char** then I think it would implicitly do the const cast, or use const_cast() explicitly.
igagis
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.