Enhance local expansion of hybrid definitions#1008
Merged
Conversation
|
Formatting check succeeded! |
c-schuler
requested changes
Apr 24, 2026
Contributor
c-schuler
left a comment
c-schuler
left a comment
There was a problem hiding this comment.
Looks mostly good. Note the possible issues I commented.
I would suggest adding some additional testing for those issues:
- test for the filter + explicit-concept or filter + valueSet-reference case, which would likely currently pass with incorrect results.
- test for a compose with exclude + explicit concepts, which would likely also pass with incorrect results
- test confirming the fallback $expand path still preserves version
c-schuler
approved these changes
Apr 29, 2026
Contributor
c-schuler
left a comment
c-schuler
left a comment
There was a problem hiding this comment.
Looks good pending test fixes. One nit is that ExpandHelper.groupExpand() is no longer used - dead code.
Nice work!
sliver007
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.