Use HAPI Repository interface#654
Conversation
|
Formatting check succeeded! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #654 +/- ##
============================================
- Coverage 70.95% 70.88% -0.07%
Complexity 153 153
============================================
Files 473 473
Lines 22189 22196 +7
Branches 2898 2903 +5
============================================
- Hits 15744 15734 -10
- Misses 4990 5004 +14
- Partials 1455 1458 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| import org.hl7.fhir.instance.model.api.IIdType; | ||
|
|
||
| /** | ||
| * @deprecated |
There was a problem hiding this comment.
Where did this requirement come from?
There was a problem hiding this comment.
We've been working towards moving this interface down into HAPI for awhile now. That happened with the 8.0.0 release.
| import static org.opencds.cqf.fhir.test.Resources.getResourcePath; | ||
|
|
||
| import ca.uhn.fhir.context.FhirContext; | ||
| import ca.uhn.fhir.repository.Repository; |
There was a problem hiding this comment.
What happens if we need to update this interface? Will we now have to wait at least one more release cycle to propagate it to clinical-reasoning + cdr-cr? Meaning, with a dependency sequence of hapi-fhir <- clinical-reasoning <- cdr-cr.
There was a problem hiding this comment.
Yes, and we already have that dependency for the models. Ideally this interface will not be changing often, if at all.
|
|
Work moved to another PR |
2 participants
Deprecate the CR Repository interface and use the new HAPI Repository interface in its place.