Skip to content

Use HAPI Repository interface and classes#659

Merged
JPercival merged 29 commits into
masterfrom
deprecate-repository-and-use-hapi-2
Jun 18, 2025
Merged

Use HAPI Repository interface and classes#659
JPercival merged 29 commits into
masterfrom
deprecate-repository-and-use-hapi-2

Conversation

@barhodes
Copy link
Copy Markdown
Contributor

Deprecate the CR Repository interfaces and use the new HAPI Repository interfaces in their place.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2025

Formatting check succeeded!

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2025

Codecov Report

Attention: Patch coverage is 68.14159% with 36 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@45bdf75). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ncds/cqf/fhir/cr/hapi/config/CrCdsHooksConfig.java 0.00% 15 Missing ⚠️
...ds/cqf/fhir/utility/repository/RestRepository.java 0.00% 9 Missing ⚠️
...ava/org/opencds/cqf/fhir/utility/BundleHelper.java 30.00% 6 Missing and 1 partial ⚠️
...rg/opencds/cqf/fhir/utility/ResourceValidator.java 0.00% 2 Missing ⚠️
...f/fhir/cr/hapi/config/test/TestCdsHooksConfig.java 0.00% 1 Missing ⚠️
...hir/utility/repository/InMemoryFhirRepository.java 88.88% 0 Missing and 1 partial ⚠️
...s/cqf/fhir/utility/repository/ig/IgRepository.java 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #659   +/-   ##
=========================================
  Coverage          ?   72.14%           
  Complexity        ?      123           
=========================================
  Files             ?      469           
  Lines             ?    21958           
  Branches          ?     2849           
=========================================
  Hits              ?    15842           
  Misses            ?     4705           
  Partials          ?     1411           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JPercival JPercival marked this pull request as ready for review May 29, 2025 17:20
Comment thread pom.xml
Comment thread pom.xml
Copy link
Copy Markdown
Contributor

@epeartree epeartree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at one comment in particular where i'm showing that a multiMap entry may be lost when flattened hashMap.

the other 4 comments are nitpicks which can be ignored.

@sonarqubecloud
Copy link
Copy Markdown

@JPercival JPercival merged commit 0efebcc into master Jun 18, 2025
10 checks passed
@JPercival JPercival deleted the deprecate-repository-and-use-hapi-2 branch June 18, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants