Skip to content

Add direct reference codes to manifest during $release#665

Merged
barhodes merged 5 commits into
masterfrom
cor-add-direct-references-codes
May 16, 2025
Merged

Add direct reference codes to manifest during $release#665
barhodes merged 5 commits into
masterfrom
cor-add-direct-references-codes

Conversation

@Chris0296
Copy link
Copy Markdown
Collaborator

@Chris0296 Chris0296 commented May 13, 2025

Update $release operation to gather any direct-reference codes referenced by component measures and add them to the manifest, using the directReferenceCode extension slice on the root of the release manifest.

Functionality handles STU4/STU5+, works with cqfm-directReferenceCode (STU4) and cqf-directReferenceCode (STU5) in the Measure source, output is always cqf-directReferenceCode extensions in the Manifest because cqfm-directReferenceCode isn't allowed in a CRMIManifest.

@Chris0296 Chris0296 linked an issue May 13, 2025 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2025

Formatting check succeeded!

@Chris0296 Chris0296 force-pushed the cor-add-direct-references-codes branch from 8ff4c3e to 9c1375b Compare May 13, 2025 19:44
@Chris0296 Chris0296 force-pushed the cor-add-direct-references-codes branch from 9c1375b to 051b0f5 Compare May 13, 2025 19:45
@Chris0296
Copy link
Copy Markdown
Collaborator Author

Copying question from the related issue here:

"Is it safe to assume that STU4 will always have 'cqfm-directReferenceCode' and STU5 will always have 'cqf-directReferenceCode' or are both extension URLs valid for both versions?"

This implementation assumes the former.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.55%. Comparing base (d36ab2c) to head (f528e81).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...opencds/cqf/fhir/cr/visitor/r4/ReleaseVisitor.java 91.66% 0 Missing and 1 partial ⚠️
...opencds/cqf/fhir/cr/visitor/r5/ReleaseVisitor.java 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #665      +/-   ##
============================================
+ Coverage     71.52%   71.55%   +0.03%     
  Complexity      153      153              
============================================
  Files           475      475              
  Lines         22270    22301      +31     
  Branches       2868     2873       +5     
============================================
+ Hits          15928    15957      +29     
  Misses         4922     4922              
- Partials       1420     1422       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@brynrhodes brynrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test needs fixup on the cqf- extension spelling, it's an extension pack extension, so it's URL is just http://hl7.org/fhir/StructureDefinition/cqf-directReferenceCode, (i.e. remove the us/cqfmeasures part from the canonical)

@Chris0296 Chris0296 requested a review from brynrhodes May 14, 2025 15:21
@barhodes barhodes enabled auto-merge (squash) May 16, 2025 16:49
@sonarqubecloud
Copy link
Copy Markdown

@barhodes barhodes merged commit 9cb665b into master May 16, 2025
10 checks passed
@barhodes barhodes deleted the cor-add-direct-references-codes branch May 16, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add direct-reference codes to the manifest

3 participants