Skip to content

applySetScoring config, fix non resourceType population basis, fix measureScoring when <0#671

Merged
Capt-Mac merged 3 commits into
masterfrom
apply_set_scoring
Jun 9, 2025
Merged

applySetScoring config, fix non resourceType population basis, fix measureScoring when <0#671
Capt-Mac merged 3 commits into
masterfrom
apply_set_scoring

Conversation

@Capt-Mac
Copy link
Copy Markdown
Contributor

@Capt-Mac Capt-Mac commented Jun 9, 2025

Configuration applySetScoring unit tests

population-basis that are not-resourceTypes and not boolean hit an iterable casting error. Test is used on 'Period' to mimic the error.

measureScoring on measure expressions with applySetScoring have possiblity of attempting to score < 0 or divide by 0, this merge corrects this.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 9, 2025

Formatting check succeeded!

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 85.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 71.25%. Comparing base (aff1457) to head (f41e473).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...s/cqf/fhir/cr/measure/common/MeasureEvaluator.java 85.18% 2 Missing and 6 partials ⚠️
.../cqf/fhir/cr/measure/r4/R4MeasureReportScorer.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #671      +/-   ##
============================================
+ Coverage     71.20%   71.25%   +0.05%     
  Complexity      153      153              
============================================
  Files           473      473              
  Lines         22286    22291       +5     
  Branches       2880     2880              
============================================
+ Hits          15869    15884      +15     
+ Misses         4987     4982       -5     
+ Partials       1430     1425       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 9, 2025

@Capt-Mac Capt-Mac merged commit d29f55d into master Jun 9, 2025
10 checks passed
@Capt-Mac Capt-Mac deleted the apply_set_scoring branch June 9, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants