applySetScoring config, fix non resourceType population basis, fix measureScoring when <0#671
Merged
Conversation
…ssue with FHIRTypes that are not resourceType
|
Formatting check succeeded! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #671 +/- ##
============================================
+ Coverage 71.20% 71.25% +0.05%
Complexity 153 153
============================================
Files 473 473
Lines 22286 22291 +5
Branches 2880 2880
============================================
+ Hits 15869 15884 +15
+ Misses 4987 4982 -5
+ Partials 1430 1425 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
lukedegruchy
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Configuration applySetScoring unit tests
population-basis that are not-resourceTypes and not boolean hit an iterable casting error. Test is used on 'Period' to mimic the error.
measureScoring on measure expressions with applySetScoring have possiblity of attempting to score < 0 or divide by 0, this merge corrects this.