Pull requests into cql-execution require the following. Submitter and reviewer should ✔ when done. For items that are not-applicable, mark "N/A" and ✔.
Submitter:
- This pull request describes why these changes were made
- Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
- Tests are included and test edge cases
- Tests have been run locally and pass
- Code coverage has not gone down and all code touched or added is covered.
- Code passes lint and prettier (hint: use
npm run checkto run tests, lint, and prettier) - All dependent libraries are appropriately updated or have a corresponding PR related to this change Reviewer:
Name:
- Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
- The tests appropriately test the new code, including edge cases
- You have tried to break the code