Skip to content

Commit 989d222

Browse files
Feature/disable hover support (#124)
* disable hover related tests * updates version to 4.4.0
1 parent 5475d4f commit 989d222

10 files changed

Lines changed: 24 additions & 7 deletions

File tree

core/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<parent>
1313
<groupId>org.opencds.cqf.cql.ls</groupId>
1414
<artifactId>cql-ls</artifactId>
15-
<version>4.4.0-SNAPSHOT</version>
15+
<version>4.4.0</version>
1616
<relativePath>../pom.xml</relativePath>
1717
</parent>
1818

debug/server/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<parent>
1313
<groupId>org.opencds.cqf.cql.ls</groupId>
1414
<artifactId>cql-ls</artifactId>
15-
<version>4.4.0-SNAPSHOT</version>
15+
<version>4.4.0</version>
1616
<relativePath>../../pom.xml</relativePath>
1717
</parent>
1818

debug/service/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<parent>
1313
<groupId>org.opencds.cqf.cql.ls</groupId>
1414
<artifactId>cql-ls</artifactId>
15-
<version>4.4.0-SNAPSHOT</version>
15+
<version>4.4.0</version>
1616
<relativePath>../../pom.xml</relativePath>
1717
</parent>
1818

ls/server/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<parent>
1313
<groupId>org.opencds.cqf.cql.ls</groupId>
1414
<artifactId>cql-ls</artifactId>
15-
<version>4.4.0-SNAPSHOT</version>
15+
<version>4.4.0</version>
1616
<relativePath>../../pom.xml</relativePath>
1717
</parent>
1818

ls/server/src/main/java/org/opencds/cqf/cql/ls/server/provider/HoverProvider.kt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,12 @@ import org.opencds.cqf.cql.ls.server.manager.CqlCompilationManager
1616
class HoverProvider(private val cqlCompilationManager: CqlCompilationManager) {
1717

1818
fun hover(position: HoverParams): Hover? {
19+
// Returning null here effectively disables hover functionality from the server side.
20+
// 2026-03-30 RGT: Disable hover functionality for now.
21+
// The LibraryManager caching issues is causing the CQL Compiler to continutally fire.
22+
// This is affect performance, revist hover functionality later.
23+
return null
24+
1925
val uri = Uris.parseOrNull(position.textDocument.uri) ?: return null
2026

2127
// This translates on the fly. We may want to consider maintaining

ls/server/src/test/java/org/opencds/cqf/cql/ls/server/LanguageServerTest.kt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import org.junit.jupiter.api.Assertions.assertNotNull
1616
import org.junit.jupiter.api.Assertions.assertNull
1717
import org.junit.jupiter.api.Assertions.assertTrue
1818
import org.junit.jupiter.api.BeforeAll
19+
import org.junit.jupiter.api.Disabled
1920
import org.junit.jupiter.api.Test
2021
import org.junit.jupiter.api.assertDoesNotThrow
2122
import org.mockito.Mockito
@@ -71,6 +72,7 @@ class LanguageServerTest {
7172
assertNotNull(server)
7273
}
7374

75+
@Disabled("Disabled until LibraryManager caching issues are resolved")
7476
@Test
7577
fun hoverInt() {
7678
val hover = server.getTextDocumentService()
@@ -85,6 +87,7 @@ class LanguageServerTest {
8587
assertEquals("```cql\nSystem.Integer\n```", markup.value)
8688
}
8789

90+
@Disabled("Disabled until LibraryManager caching issues are resolved")
8891
@Test
8992
fun hoverNothing() {
9093
val hover = server.getTextDocumentService()
@@ -94,6 +97,7 @@ class LanguageServerTest {
9497
assertNull(hover)
9598
}
9699

100+
@Disabled("Disabled until LibraryManager caching issues are resolved")
97101
@Test
98102
fun hoverList() {
99103
val hover = server.getTextDocumentService()
@@ -124,6 +128,7 @@ class LanguageServerTest {
124128
assertNotNull(result.capabilities)
125129
}
126130

131+
@Disabled("Disabled until LibraryManager caching issues are resolved")
127132
@Test
128133
fun initialize_setsHoverProviderCapability() {
129134
val result = server.initialize(InitializeParams()).get()

ls/server/src/test/kotlin/org/opencds/cqf/cql/ls/server/provider/HoverProviderTest.kt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import org.junit.jupiter.api.Assertions.assertEquals
77
import org.junit.jupiter.api.Assertions.assertNotNull
88
import org.junit.jupiter.api.Assertions.assertNull
99
import org.junit.jupiter.api.BeforeAll
10+
import org.junit.jupiter.api.Disabled
1011
import org.junit.jupiter.api.Test
1112
import org.opencds.cqf.cql.ls.server.manager.CompilerOptionsManager
1213
import org.opencds.cqf.cql.ls.server.manager.CqlCompilationManager
@@ -27,6 +28,7 @@ class HoverProviderTest {
2728
}
2829
}
2930

31+
@Disabled("Disabled until LibraryManager caching issues are resolved")
3032
@Test
3133
fun hoverInt() {
3234
val hover =
@@ -45,6 +47,7 @@ class HoverProviderTest {
4547
assertEquals("```cql\nSystem.Integer\n```", markup.value)
4648
}
4749

50+
@Disabled("Disabled until LibraryManager caching issues are resolved")
4851
@Test
4952
fun hoverNothing() {
5053
val hover =
@@ -58,6 +61,7 @@ class HoverProviderTest {
5861
assertNull(hover)
5962
}
6063

64+
@Disabled("Disabled until LibraryManager caching issues are resolved")
6165
@Test
6266
fun hoverList() {
6367
val hover =
@@ -76,6 +80,7 @@ class HoverProviderTest {
7680
assertEquals("```cql\nlist<System.Integer>\n```", markup.value)
7781
}
7882

83+
@Disabled("Disabled until LibraryManager caching issues are resolved")
7984
@Test
8085
fun hoverOnLibraryRef() {
8186
// Line 5 (0-indexed): " 1 + One."One"" — position (5, 8) is 'O' in 'One'
@@ -95,6 +100,7 @@ class HoverProviderTest {
95100
assertEquals("```cql\nSystem.Integer\n```", markup.value)
96101
}
97102

103+
@Disabled("Disabled until LibraryManager caching issues are resolved")
98104
@Test
99105
fun hoverOnDefineName() {
100106
// Line 4 (0-indexed): "define "Two":" — position (4, 8) is 'T' inside the define name

ls/service/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<parent>
1212
<groupId>org.opencds.cqf.cql.ls</groupId>
1313
<artifactId>cql-ls</artifactId>
14-
<version>4.4.0-SNAPSHOT</version>
14+
<version>4.4.0</version>
1515
<relativePath>../../pom.xml</relativePath>
1616
</parent>
1717

plugin/debug/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<parent>
1212
<groupId>org.opencds.cqf.cql.ls</groupId>
1313
<artifactId>cql-ls</artifactId>
14-
<version>4.4.0-SNAPSHOT</version>
14+
<version>4.4.0</version>
1515
<relativePath>../../pom.xml</relativePath>
1616
</parent>
1717

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<groupId>org.opencds.cqf.cql.ls</groupId>
66
<artifactId>cql-ls</artifactId>
77
<packaging>pom</packaging>
8-
<version>4.4.0-SNAPSHOT</version>
8+
<version>4.4.0</version>
99

1010
<name>CQL Language Server</name>
1111
<description>A Language Server for CQL implementing the LSP</description>

0 commit comments

Comments
 (0)