Fix error-expecting test handling in CLI and server runners - #105
Open
bryantaustin13 wants to merge 1 commit into
Open
Fix error-expecting test handling in CLI and server runners#105bryantaustin13 wants to merge 1 commit into
bryantaustin13 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outputless tests marked invalid="true"/"semantic" are no longer skipped —
they expect an engine error. Add responseIndicatesError() to detect errors
via a non-2xx status or an "evaluation error" parameter, and route both the
CLI (test-runner) and server (test-execution-service) paths through it;
guard cvl.parse against an undefined expected value.
Also set axios validateStatus so the CLI no longer throws on non-2xx,
matching the fetch path (a non-2xx previously scored "error" on the CLI but
"pass"/"fail" on the server).
Update run-tests.test.ts to build the results-shared mock from importActual
so the new responseIndicatesError export survives.