TS-43260 Profiler crash fix in case of invalid config options#882
Open
stahlbauer wants to merge 1 commit intomasterfrom
Open
TS-43260 Profiler crash fix in case of invalid config options#882stahlbauer wants to merge 1 commit intomasterfrom
stahlbauer wants to merge 1 commit intomasterfrom
Conversation
DreierF
reviewed
Apr 21, 2026
Comment on lines
+100
to
+102
| // Don't crash the profiled application due to a configuration error | ||
| // (see TS-43260). The error has already been logged in getAndApplyAgentOptions. | ||
| return; |
Contributor
There was a problem hiding this comment.
The TI team discussed the topic and came to the (surprising) decision, that the agent should never crash the profiled application even if the agent is configured incorrectly. Can you please adjust the other places where we currently re-throw exceptions, document this decision in the code and adjust the tests if necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue TS-43260
Please respect the vote of the Teamscale bot or flag irrelevant findings as tolerated or false positives. If you feel that the Teamscale config needs adjustment, please state so in a comment and discuss this with your reviewer.