Add a self-maintained Electron assessment fixture and CI#5
Open
gronke wants to merge 1 commit into
Open
Conversation
`crates/fixtures` builds a synthetic, deliberately-vulnerable Electron app from committed source: a packed `electron-sample.asar` and a minimal `ElectronSample.app`. Every defect is intentional — `sandbox: false`, `nodeIntegration: true`, `contextIsolation: false` and `webSecurity: false` in `main.js`, no CSP in `index.html`, a `lodash@4.17.20` dependency, weak App Transport Security flags and a registered URL scheme in `Info.plist`, and a correct `ElectronAsarIntegrity` hash. `expected.json` lists the findings to expect. The `assess` bin compares the `detect`, `static-scan` and `audit` output to it as plain JSON, so the crate depends on none of the analysis crates. `.github/workflows/fixtures.yml` builds the target on Linux, then runs the analyzers against it on macOS, the default bundle path, and checks the manifest. The workflow runs read-only because the fixture is untrusted.
gronke
force-pushed
the
fixtures/electron-sample
branch
from
3f7b976 to
a5e3d01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce an intentionally vulnerable Electron fixture for roundtrip tests.