fix bug reading config from Cargo.toml#377
Conversation
…d even when only certain ones are manually specified
|
I wonder if that'll be a breaking change for somebody 🤔 Anyway, thanks for the PR! Would you mind adding a small changefile for this? (check the .changes dir for examples) |
|
I was getting really confused trying to figure out why the binaries config wasn't working. Hopefully this can save people that trouble in the future. Added a changefile! |
|
sorry for the delay here! for some reason it didn't show up in my notifications :( |
|
I'm just commenting that yes, this was a breaking change for somebody. Consequently, this patch should either have been released as 0.12.0 (with an explicit breaking comment) or, preferably, with a command-line switch that has default off. |
|
sorry about that! new minor version + better comment would have been a good idea. the old behavior did explicitly violate what the documentation says should happen though. |
Existing version has a problem where it adds all bin targets from the cargo.toml even if only specific binaries are listed, making it impossible to exclude any target.