Skip to content

fix bug reading config from Cargo.toml#377

Merged
FabianLars-crabnebula merged 2 commits into
crabnebula-dev:mainfrom
PWhiddy:patch-1
Nov 26, 2025
Merged

fix bug reading config from Cargo.toml#377
FabianLars-crabnebula merged 2 commits into
crabnebula-dev:mainfrom
PWhiddy:patch-1

Conversation

@PWhiddy
Copy link
Copy Markdown
Contributor

@PWhiddy PWhiddy commented Oct 16, 2025

Existing version has a problem where it adds all bin targets from the cargo.toml even if only specific binaries are listed, making it impossible to exclude any target.

…d even when only certain ones are manually specified
@FabianLars-crabnebula
Copy link
Copy Markdown
Contributor

I wonder if that'll be a breaking change for somebody 🤔 Anyway, thanks for the PR! Would you mind adding a small changefile for this? (check the .changes dir for examples)

@PWhiddy
Copy link
Copy Markdown
Contributor Author

PWhiddy commented Oct 20, 2025

I was getting really confused trying to figure out why the binaries config wasn't working. Hopefully this can save people that trouble in the future.

Added a changefile!

@FabianLars-crabnebula
Copy link
Copy Markdown
Contributor

sorry for the delay here! for some reason it didn't show up in my notifications :(

@sfried
Copy link
Copy Markdown

sfried commented Jan 6, 2026

I'm just commenting that yes, this was a breaking change for somebody. Consequently, this patch should either have been released as 0.12.0 (with an explicit breaking comment) or, preferably, with a command-line switch that has default off.

@PWhiddy
Copy link
Copy Markdown
Contributor Author

PWhiddy commented Jan 6, 2026

sorry about that! new minor version + better comment would have been a good idea. the old behavior did explicitly violate what the documentation says should happen though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants