From 775fb3d8f26ad380a635ad028a6ca85169204caa Mon Sep 17 00:00:00 2001 From: James Q Barclay Date: Mon, 2 Mar 2026 12:06:31 +0100 Subject: [PATCH 1/2] fix(ci): use cargo build for dioxus example The dioxus example is a plain desktop app with no dx-specific features. Replace `dx build` with `cargo build --release` so the binary lands in `target/release/` where cargo-packager expects it. This fixes the package CI job on all three platforms: - macOS/Windows: binary now at the expected path - Ubuntu: no longer requires GLIBC 2.38+ from the dx binary Remove the `cargo binstall dioxus-cli` CI step (no longer needed). --- .github/workflows/build-examples.yml | 1 - examples/dioxus/Cargo.toml | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/build-examples.yml b/.github/workflows/build-examples.yml index 5df6642b..45761978 100644 --- a/.github/workflows/build-examples.yml +++ b/.github/workflows/build-examples.yml @@ -39,6 +39,5 @@ jobs: - run: go install github.com/wailsapp/wails/v2/cmd/wails@latest - run: cargo install cargo-binstall --locked - run: cargo binstall tauri-cli --locked --force - - run: cargo binstall dioxus-cli --locked --force - run: cargo r --package cargo-packager -- signer generate --password '123' --path ./signing-key -vvv - run: cargo r --package cargo-packager -- --release --private-key ./signing-key --password '123' --formats all -vvv diff --git a/examples/dioxus/Cargo.toml b/examples/dioxus/Cargo.toml index abbd9961..37efd081 100644 --- a/examples/dioxus/Cargo.toml +++ b/examples/dioxus/Cargo.toml @@ -8,7 +8,7 @@ publish = false dioxus = { version = "0.7", features = ["desktop"] } [package.metadata.packager] -before-packaging-command = "dx build --platform desktop --release" +before-packaging-command = "cargo build --release" out-dir = "./dist" product-name = "Dioxus example" identifier = "com.dioxus.example" From 7c12b4f4d96801f22ccac5dc58166c44b84ec4d5 Mon Sep 17 00:00:00 2001 From: Fabian-Lars <118197967+FabianLars-crabnebula@users.noreply.github.com> Date: Tue, 3 Mar 2026 10:19:55 +0100 Subject: [PATCH 2/2] add todo --- examples/dioxus/Cargo.toml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/dioxus/Cargo.toml b/examples/dioxus/Cargo.toml index 37efd081..5f5d26e6 100644 --- a/examples/dioxus/Cargo.toml +++ b/examples/dioxus/Cargo.toml @@ -8,6 +8,8 @@ publish = false dioxus = { version = "0.7", features = ["desktop"] } [package.metadata.packager] +# TODO: Needs https://github.com/crabnebula-dev/cargo-packager/issues/360 +# before-packaging-command = "dx build --platform desktop --release" before-packaging-command = "cargo build --release" out-dir = "./dist" product-name = "Dioxus example"