feat(updater): require authenticated signed metadata, ref #433#435
Open
lucasfernog-crabnebula wants to merge 3 commits into
Open
feat(updater): require authenticated signed metadata, ref #433#435lucasfernog-crabnebula wants to merge 3 commits into
lucasfernog-crabnebula wants to merge 3 commits into
Conversation
Embed the release version (and timestamp) into the signed minisign trusted comment when packaging, and require the updater to verify that the manifest's advertised version matches the signed one. Updates whose signatures lack this authenticated metadata are rejected, defeating downgrade/freeze/replay attacks. Adds `signature_expiration` to reject stale signatures, and version-aware signer entry points. Update the cargo-packager CLI in your release pipeline so the metadata is signed.
Member
Author
|
ref #433 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Embed the release version (and timestamp) into the signed minisign trusted comment when packaging, and require the updater to verify that the manifest's advertised version matches the signed one. Updates whose signatures lack this authenticated metadata are rejected, defeating downgrade/freeze/replay attacks. Adds
signature_expirationto reject stale signatures, and version-aware signer entry points. Update the cargo-packager CLI in your release pipeline so the metadata is signed.