pass crackme object to solution_create and set has_markdown for uploaded markdown files

Author: 3rdit

app/controllers/solution.py

@@ -26,6 +26,7 @@
 MAX_INFO_LENGTH = 200
 MAX_CONTENT_LENGTH = 50000
 MIN_CONTENT_LENGTH = 200
+MARKDOWN_EXTENSIONS = frozenset({'.md', '.txt', '.markdown'})
 
 
 def _get_crackme_or_abort(hexid):
@@ -145,9 +146,11 @@ def upload_solution_post(hexidcrackme):
         return redirect(redirect_url)
 
     original_filename = secure_filename(file.filename) or "unnamed"
+    ext = os.path.splitext(original_filename)[1].lower()
+    has_markdown = ext in MARKDOWN_EXTENSIONS
 
     try:
-        solution, crackme = solution_create(info, username, hexidcrackme, original_filename)
+        solution = solution_create(info, username, crackme, original_filename, has_markdown)
     except Exception as e:
         print(f"Error creating solution: {e}")
         abort(500)
@@ -225,7 +228,7 @@ def editor_solution_post(hexidcrackme):
         return redirect(redirect_url)
 
     try:
-        solution, crackme = solution_create(info, username, hexidcrackme, original_filename='writeup.md', has_markdown=True)
+        solution = solution_create(info, username, crackme, 'writeup.md', has_markdown=True)
     except Exception as e:
         print(f"Error creating solution: {e}")
         abort(500)

app/models/solution.py

@@ -125,15 +125,11 @@ def get_solution_authors(crackme_hexid):
     return set(solution['author'] for solution in solutions)
 
 
-def solution_create(info, username, crackme_hexid, original_filename=None, has_markdown=False):
+def solution_create(info, username, crackme, original_filename=None, has_markdown=False):
     """Create a new solution."""
     if not check_connection():
         raise ErrUnavailable("Database is unavailable")
 
-    # Get the crackme
-    from app.models.crackme import crackme_by_hexid
-    crackme = crackme_by_hexid(crackme_hexid)
-
     collection = get_collection('solution')
     obj_id = ObjectId()
 
@@ -153,4 +149,4 @@ def solution_create(info, username, crackme_hexid, original_filename=None, has_m
     }
 
     collection.insert_one(solution)
-    return solution, crackme
+    return solution