Skip to content

Commit 5f9eea1

Browse files
committed
Normalize signed ESI URLs
1 parent bc6fb5f commit 5f9eea1

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

src/signing/UrlSigner.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@
1010
use HttpMessageSignatures\Url\UrlSigningConfig;
1111
use HttpMessageSignatures\Url\UrlVerifier as HttpUrlVerifier;
1212
use League\Uri\Components\Query;
13+
use League\Uri\Exceptions\SyntaxError;
1314
use League\Uri\Modifier;
1415
use League\Uri\UriString;
15-
use Throwable;
1616

1717
class UrlSigner
1818
{
@@ -33,10 +33,10 @@ public function verify(string $url): bool
3333
{
3434
try {
3535
$normalizedUrl = $this->normalizeUrlForSigning($url);
36-
} catch (Throwable $e) {
37-
Craft::info([
38-
'message' => 'Invalid URL signature',
39-
'reason' => sprintf('URL could not be normalized: %s', $e->getMessage()),
36+
} catch (SyntaxError $e) {
37+
Craft::warning([
38+
'message' => 'Malformed signed URL',
39+
'reason' => $e->getMessage(),
4040
'url' => $url,
4141
'signatureParameter' => $this->signatureParameter,
4242
], __METHOD__);

0 commit comments

Comments
 (0)