[5.x]: Unable to delete re-registered user

[berrytimmermans]

What happened?

Description

When a user account is deleted from the Craft CMS back-end, and that same user subsequently re-registers via the front-end using the same email address, it becomes impossible to delete the newly created account. The delete action appears to succeed (a confirmation dialog is shown and accepted), but the user remains present in the system after the grid reloads.

Steps to reproduce

1. Delete an existing user account from the Craft CMS control panel.
2. Have that same user re-register an account via the front-end of the site, using the same email address as the previously deleted account.
3. Navigate to Settings > Users > All Users in the control panel.
4. Select the re-registered user from the list.
5. Click the gear icon (settings wheel) and choose the delete option.
6. When prompted with “Are you sure you want to delete this user?”, click OK.
7. Observe that the user grid reloads but the user is still present.
8. Alternatively, open the user detail page and use the “Delete user” button — the same result occurs.

Expected behavior

After confirming the deletion prompt, the user should be permanently removed from the system. The user grid should reload without the deleted user account.

Actual behavior

After confirming the deletion prompt (“Are you sure you want to delete this user?” → OK), the user grid reloads but the user account remains visible and active. This occurs both via the gear icon in the All Users overview and via the “Delete user” button on the user detail page. The deletion silently fails with no error message displayed.

Craft CMS version

5.10.2

PHP version

8.3.31

Operating system and version

Linux 4.18.0-553.117.1.el8_10.x86_64

Database type and version

MariaDB 10.5.29

Image driver and version

Imagick 3.8.1 (ImageMagick 6.9.13-25)

Installed plugins and versions

• Craft Commerce: 5.6.5
• Digital Products: 4.0.3
• Freeform: 5.15.13
• Link Vault: 5.0.3
• Mollie for Craft Commerce: 4.4.1
• Redactor: 4.2.0
• Redactor Anchors: 1.5.0

[linear-code]

CMS-2170

[brandonkelly]

Hi, thanks for reporting that.

Unfortunately I’m not able to reproduce.

Can you try clearing your data caches after deleting the user, just to ensure this isn’t a caching issue?

If you are able to send a database backup and your Composer files into support@craftcms.com, we can look into it further from there. Please note which user isn’t getting deleted properly.

[berrytimmermans]

Thanks for your response. I had already cleared the caches to rule that out. I can also reproduce the issue both locally and on production. I will send you the data as requested.

[tommysvr]

Thanks for the files! I'm able to reproduce on that site and on a fresh install (5.10.5)
It looks to be due to the user having orders in Commerce rather than front-end/CP created.

Steps:

1. Create a user and then an order in Commerce with that user
2. Delete the user
3. Deletion blockers added in 5.10 don't show
4. Index refreshes, user still shows but no errors in the browser or logs

Edit to add: disabling Commerce allows you to delete the user

[berrytimmermans]

Thank you Tommy, for your response. What I do wonder is why I was able to delete the user in the first place. At that time, this user already had Commerce orders as well.

[i-just]

Thanks for all the info!

The deletion blockers were introduced in the cms v5.10.0, and Commerce will start using them as of version 5.7.0 (should be out soon).

The current behaviour is that when you attempt to delete a user who has commerce orders against them, a log item will be written. For example: Unable to delete user 216: the user has a Craft Commerce order. Also, you should see a generic error message on the screen - the fact that no message is shown is a bug, and I raised a PR for it.

(Previous items that provide more info/context on this: #13290 and craftcms/commerce#3686.)

why I was able to delete the user in the first place

Are you able to reproduce deleting a User who has Commerce orders against them?

[berrytimmermans]

To dive a little deeper into this, I restored a database backup from before I deleted the user for the first time. It turns out this user had no Commerce orders, and I was able to delete them without any issues.

However, when I recreate the user through the front-end, I am again unable to delete them. If I restore the same backup once more and add the same email address through the control panel instead, I am able to delete the user without any problems.

I can provide this database via support@craftcms.com if you like?

[berrytimmermans]

As an additional note: I was able to delete the user as long as they had not yet been activated via the activation email. Once I send the activation email and the user activates their account, I am no longer able to delete them, even if I deactivate the user first.

[i-just]

Thanks for the extra info!

I can provide this database via support@craftcms.com if you like?

Yes, please! If you could send the database backup from before you first deleted the user and then from after they were recreated through the front-end, that would be perfect. Also, please let us know the user's email address.

[berrytimmermans]

Just sent it over, you should receive it shortly!

[i-just]

Hi @berrytimmermans, I don’t believe we received the last database backups. Any chance you could re-send it, please?