Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/services/ProjectConfig.php
Original file line number Diff line number Diff line change
Expand Up @@ -1486,8 +1486,16 @@ private function _getPendingChanges(?array $configData = null, bool $existsOnly

unset($removedItem);

// Sort by number of dots to ensure deepest paths listed first
// Sort by top-level key first, then deepest paths first within each group.
$sorter = function($a, $b) {
$aTop = explode('.', $a, 2)[0];
$bTop = explode('.', $b, 2)[0];
$topCmp = strcmp($aTop, $bTop);

if ($topCmp !== 0) {
return $topCmp;
}

$aDepth = ProjectConfigHelper::pathDepth($a);
$bDepth = ProjectConfigHelper::pathDepth($b);
return $bDepth <=> $aDepth;
Expand Down
65 changes: 65 additions & 0 deletions tests/unit/services/ProjectConfigTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@

use Codeception\Stub\Expected;
use Craft;
use craft\elements\Category;
use craft\helpers\StringHelper;
use craft\models\ProjectConfigData;
use craft\models\ReadOnlyProjectConfigData;
use craft\mutex\Mutex;
use craft\mutex\NullMutex;
Expand Down Expand Up @@ -216,6 +218,69 @@ public function testEventsFiredAndDeltaStored(): void
$pc->saveModifiedConfigData();
}

public function testApplyingConfigChangesDoesNotExposePartialElementSourcesToSectionHandlers(): void
{
$projectConfig = new ProjectConfig();
$internalConfig = new ReadOnlyProjectConfigData([], $projectConfig);
$currentWorkingConfig = new ProjectConfigData([], $projectConfig);

$internalConfigProperty = new \ReflectionProperty(ProjectConfig::class, '_internalConfig');
$internalConfigProperty->setValue($projectConfig, $internalConfig);

$currentWorkingConfigProperty = new \ReflectionProperty(ProjectConfig::class, '_currentWorkingConfig');
$currentWorkingConfigProperty->setValue($projectConfig, $currentWorkingConfig);

$incomingConfig = [
'elementSources' => [
'craft\\elements\\Category' => [[
'defaultSort' => ['structure', 'asc'],
'tableAttributes' => ['link'],
'type' => 'native',
'key' => 'group:bedad454-861f-4d7f-b0f6-40ce023cffc5',
'disabled' => false,
]],
],
'sections' => [
'aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa' => [
'siteSettings' => [
'bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb' => [
'hasUrls' => true,
'uriFormat' => 'test/{slug}',
'template' => 'test/_entry',
'enabledByDefault' => true,
],
],
'entryTypes' => ['cccccccc-cccc-cccc-cccc-cccccccccccc'],
],
],
];

$externalConfig = new ReadOnlyProjectConfigData($incomingConfig, $projectConfig);
$externalConfigProperty = new \ReflectionProperty(ProjectConfig::class, '_externalConfig');
$externalConfigProperty->setValue($projectConfig, $externalConfig);

$originalProjectConfig = Craft::$app->getProjectConfig();
$originalElementSources = Craft::$app->getElementSources();
$handlerWasCalled = false;

Craft::$app->set('projectConfig', $projectConfig);
Craft::$app->set('elementSources', new \craft\services\ElementSources());

$projectConfig->onAdd(ProjectConfig::PATH_SECTIONS . '.{uid}', function() use (&$handlerWasCalled) {
$handlerWasCalled = true;
Craft::$app->getElementSources()->getSources(Category::class);
});

try {
$projectConfig->applyConfigChanges($incomingConfig);
} finally {
Craft::$app->set('projectConfig', $originalProjectConfig);
Craft::$app->set('elementSources', $originalElementSources);
}

self::assertTrue($handlerWasCalled);
}

public function getConfigProvider(): array
{
return [
Expand Down