Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensure that empty usernames are at the end of the sorted results. In other words, if you have usernames:
abc,NULL,defand they’re all active, the default sort order should resolve toabc,def,NULLBit of history:
Users::getUserByUsernameOrEmail()method to prioritise the credentialed users (order by credentialed users first #18154);Steps to reproduce without involving Commerce:
test@test.comtest@test.comtest@test.comWithout this PR, you won’t be able to log in, as the first returned user will be the inactive one (one without a username).
With this PR, you should be able to log in as the first returned user will be the active one (one with the username).
Related issues
#18723