Skip to content

Commit a300880

Browse files
authored
Merge pull request #4329 from craftcms/nathaniel/com-585-5x-product-type-ui-label-format-fields-are-not-persisted-on
[5.x] Fixed saving product and variant UI label formats
2 parents 008ea06 + 2eaf7a8 commit a300880

3 files changed

Lines changed: 4 additions & 1 deletion

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
- Fixed a bug where inventory search was case-sensitive on PostgreSQL. ([#4326](https://github.com/craftcms/commerce/issues/4326))
66
- Fixed a bug where a Twig error would occur when creating or editing a shipping rule. ([#4321](https://github.com/craftcms/commerce/issues/4321))
7+
- Fixed a bug where settings weren’t being saved to the project config. ([#4324](https://github.com/craftcms/commerce/issues/4324))
78

89
## 5.6.6.1 - 2026-06-18
910

src/controllers/ProductTypesController.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,7 @@ public function actionSaveProductType(): ?Response
144144
$productType->hasDimensions = (bool)$this->request->getBodyParam('hasDimensions');
145145
$productType->hasProductTitleField = (bool)$this->request->getBodyParam('hasProductTitleField');
146146
$productType->productTitleFormat = $this->request->getBodyParam('productTitleFormat');
147+
$productType->productUiLabelFormat = $this->request->getBodyParam('productUiLabelFormat');
147148
$productType->productTitleTranslationMethod = $this->request->getBodyParam('productTitleTranslationMethod', $productType->productTitleTranslationMethod);
148149
$productType->productTitleTranslationKeyFormat = $this->request->getBodyParam('productTitleTranslationKeyFormat', $productType->productTitleTranslationKeyFormat);
149150
$productType->showSlugField = (bool)$this->request->getBodyParam('showSlugField', $productType->showSlugField);
@@ -152,6 +153,7 @@ public function actionSaveProductType(): ?Response
152153
$productType->maxVariants = $this->request->getBodyParam('maxVariants') ?: null;
153154
$productType->hasVariantTitleField = $this->request->getBodyParam('hasVariantTitleField', false);
154155
$productType->variantTitleFormat = $this->request->getBodyParam('variantTitleFormat');
156+
$productType->variantUiLabelFormat = $this->request->getBodyParam('variantUiLabelFormat');
155157
$productType->variantTitleTranslationMethod = $this->request->getBodyParam('variantTitleTranslationMethod', $productType->variantTitleTranslationMethod);
156158
$productType->variantTitleTranslationKeyFormat = $this->request->getBodyParam('variantTitleTranslationKeyFormat', $productType->variantTitleTranslationKeyFormat);
157159
$productType->skuFormat = $this->request->getBodyParam('skuFormat');

src/models/ProductType.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ protected function defineRules(): array
330330
['fieldLayout', 'validateFieldLayout'],
331331
['variantFieldLayout', 'validateVariantFieldLayout'],
332332
['siteSettings', 'required', 'message' => Craft::t('commerce','At least one site must be enabled for the product type.')],
333-
[['isStructure', 'defaultPlacement', 'maxLevels', 'structureId'], 'safe'],
333+
[['isStructure', 'defaultPlacement', 'maxLevels', 'structureId', 'productUiLabelFormat', 'variantUiLabelFormat'], 'safe'],
334334
[['previewTargets'], 'validatePreviewTargets'],
335335
];
336336
}

0 commit comments

Comments
 (0)