Fix review issues: translations, memory leak, destroy, storage key, ARIA, ID entropy

- Add 'View' and 'Table Columns' to en/commerce.php and InventoryAsset.php (remove unused 'View settings')
- rebuildTable: destroy old VueAdminTable before emptying DOM to prevent instance leak
- rebuildTable: add 50-attempt escape hatch to setInterval search restore
- Add destroy() override to clean up toolbar DOM, viewMenu DOM, and DisclosureMenu instance
- getStorageKey: use inventoryLocationId (per-location prefs) instead of siteUid
- Remove mismatched aria-label from View button (visible text is sufficient)
- Improve random ID entropy: substring(2) instead of substring(7)

Author: lukeholder

src/translations/en/commerce.php

@@ -1101,6 +1101,7 @@
     'Switch plan' => 'Switch plan',
     'Switch' => 'Switch',
     'System' => 'System',
+    'Table Columns' => 'Table Columns',
     'Target - The category relationship field is on the purchasable' => 'Target - The category relationship field is on the purchasable',
     'Tax & Shipping' => 'Tax & Shipping',
     'Tax (inc)' => 'Tax (inc)',
@@ -1300,6 +1301,7 @@
     'Variants not restored.' => 'Variants not restored.',
     'Variants restored.' => 'Variants restored.',
     'Variants' => 'Variants',
+    'View' => 'View',
     'View customer' => 'View customer',
     'View order' => 'View order',
     'View product type - {productType}' => 'View product type - {productType}',

src/web/assets/inventory/InventoryAsset.php

@@ -63,7 +63,6 @@ public function registerAssetFiles($view): void
                 'On Hand',
                 'Incoming',
                 'View',
-                'View settings',
                 'Table Columns',
                 'Purchasable',
                 'SKU',

src/web/assets/inventory/dist/inventory.js

@@ -49,7 +49,7 @@ Craft.Commerce.InventoryLevelsManager = Garnish.Base.extend({
 
     // random id for the admin table
     this.adminTableId =
-      'inventory-admin-table-' + Math.random().toString(36).substring(7);
+      'inventory-admin-table-' + Math.random().toString(36).substring(2);
     this.$adminTable = $('<div id="' + this.adminTableId + '"></div>').appendTo(
       this.$container
     );
@@ -59,9 +59,9 @@ Craft.Commerce.InventoryLevelsManager = Garnish.Base.extend({
 
   getStorageKey: function () {
     return (
-      'Craft-' +
-      Craft.siteUid +
-      '.Commerce.InventoryLevels.viewPreferences.' +
+      'Commerce.InventoryLevels.viewPreferences.' +
+      this.settings.inventoryLocationId +
+      '.' +
       Craft.userId
     );
   },
@@ -212,7 +212,7 @@ Craft.Commerce.InventoryLevelsManager = Garnish.Base.extend({
 
     // Generate unique ID for the menu
     this.viewMenuId =
-      'inventory-view-menu-' + Math.random().toString(36).substring(7);
+      'inventory-view-menu-' + Math.random().toString(36).substring(2);
 
     // Create a toolbar container for the view button (positioned at top right)
     this.$viewToolbar = $('<div/>', {
@@ -227,7 +227,6 @@ Craft.Commerce.InventoryLevelsManager = Garnish.Base.extend({
       type: 'button',
       class: 'btn menubtn',
       text: Craft.t('commerce', 'View'),
-      'aria-label': Craft.t('commerce', 'View settings'),
       'aria-controls': this.viewMenuId,
       'data-icon': 'sliders',
     }).appendTo(this.$viewToolbar);
@@ -352,27 +351,50 @@ Craft.Commerce.InventoryLevelsManager = Garnish.Base.extend({
     var searchValue =
       this.$container.find('.vue-admin-table input[type="search"]').val() || '';
 
-    // Remove the old table
+    // Destroy the old Vue instance before removing its DOM
+    if (this.adminTable && typeof this.adminTable.destroy === 'function') {
+      this.adminTable.destroy();
+    }
+
     this.$adminTable.empty();
 
     // Reinitialize with new columns
     this.initAdminTable();
 
     // Reapply search if there was one
     if (searchValue) {
+      var attempts = 0;
       var checkSearch = setInterval(() => {
         var $searchInput = this.$container.find(
           '.vue-admin-table input[type="search"]'
         );
-        if ($searchInput.length) {
+        if ($searchInput.length || ++attempts > 50) {
           clearInterval(checkSearch);
-          $searchInput.val(searchValue);
-          $searchInput.trigger('input');
+          if ($searchInput.length) {
+            $searchInput.val(searchValue);
+            $searchInput.trigger('input');
+          }
         }
       }, 100);
     }
   },
 
+  destroy: function () {
+    if (this.$viewToolbar) {
+      this.$viewToolbar.remove();
+    }
+    if (this.$viewMenu) {
+      this.$viewMenu.remove();
+    }
+    if (this.viewMenu && typeof this.viewMenu.destroy === 'function') {
+      this.viewMenu.destroy();
+    }
+    if (this.adminTable && typeof this.adminTable.destroy === 'function') {
+      this.adminTable.destroy();
+    }
+    this.base();
+  },
+
   defaultSettings: {
     inventoryLocationId: null,
     inventoryItemId: null,