[5.x] Add view column options to inventory screen#4193
Closed
lukeholder wants to merge 4 commits into
Closed
Conversation
lukeholder
changed the title
lukeholder
changed the title
Put options into local storage
lukeholder
force-pushed
the
feature/inventory-columns
branch
from
ef7fed1 to
388b3db
Compare
…RIA, ID entropy - Add 'View' and 'Table Columns' to en/commerce.php and InventoryAsset.php (remove unused 'View settings') - rebuildTable: destroy old VueAdminTable before emptying DOM to prevent instance leak - rebuildTable: add 50-attempt escape hatch to setInterval search restore - Add destroy() override to clean up toolbar DOM, viewMenu DOM, and DisclosureMenu instance - getStorageKey: use inventoryLocationId (per-location prefs) instead of siteUid - Remove mismatched aria-label from View button (visible text is sufficient) - Improve random ID entropy: substring(2) instead of substring(7)
lukeholder
force-pushed
the
feature/inventory-columns
branch
from
da9d531 to
b2c5e49
Compare
- Scope CROSS JOIN in getInventoryLevelQuery to the requested location when inventoryLocationId is provided, preventing a full locations x items Cartesian product from materializing before the outer WHERE filters it - Batch-load purchasables for the page in one query per element type instead of one getElementById call per row (N+1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Work in Progress.
Adds view options to the inventory screen to show/hide columns. Options are stored in local storage like the element index.
Uses the same UI as an element index.
TODO:
Related issues
#3520
#3429