fix: resolve InvalidConfigException by fixing case-sensitivity in translation category#214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found the exact cause of this crash. The issue is a simple case-sensitivity mismatch in the translation category name.
In src/models/Settings.php, the error validation message for the host name attribute is calling Craft::t() using 'Shopify' with a capital S. However, the plugin registers and configures all its translation sources using the lowercase 'shopify' category.
When a host name validation fails, the framework tries to look up the capital 'Shopify' source, can't locate it, and throws the InvalidConfigException.
I fixed this by changing the category name to lowercase 'shopify' so it matches the plugin's registered translation source and handles the validation error gracefully instead of crashing.