Fixed the bug where the wind speed was always set to auto.

[KingingWang]

#2236
Fixed a bug where the wind speed was always set to auto. The reason is that after setting the wind speed once, it would automatically change the wind speed back to auto due to setting quiet mode.

[KingingWang]

The code below will set the wind speed

IRremoteESP8266/src/IRac.cpp

Line 668 in 8fb411b

ac->setFan(ac->convertFan(fan));

After the wind speed is set, the quiet mode will be set again to reset the wind speed.

IRremoteESP8266/src/IRac.cpp

Line 670 in 8fb411b

ac->setQuiet(quiet);

After modifying the code, the wind speed can be controlled normally.

[crankyoldgit]

Looks okay to me.
It would be nice to have a unit test that confirms/shows this working the way it is expected to.

[KingingWang]

Looks okay to me. It would be nice to have a unit test that confirms/shows this working the way it is expected to.

I have tested that it can normally control the wind speed of my air conditioner. But how should I write unit tests?

[crankyoldgit]

Looks okay to me. It would be nice to have a unit test that confirms/shows this working the way it is expected to.

I have tested that it can normally control the wind speed of my air conditioner. But how should I write unit tests?

Capture what the real remote generates. i.e. the array code etc. for both cases. (for when quiet is on & off etc) and then use the library to construct the message using the functions/methods in the order etc you'd expect, and confirm that it produces the correct/same message.

e.g. Similar to this unit test in ir_Argo_test.cpp:

IRremoteESP8266/test/ir_Argo_test.cpp

Lines 121 to 147 in 5080851

	TEST(TestArgoAC_WREM3Class, MessageConstructon_ACControl) {
	IRArgoAC_WREM3 ac(kGpioUnused);
	ac.setChannel(0);
	ac.setPower(true);
	ac.setMode(argoMode_t::COOL);
	ac.setTemp(22);
	ac.setSensorTemp(26);
	ac.setFan(argoFan_t::FAN_AUTO);
	ac.setFlap(argoFlap_t::FLAP_FULL);
	ac.setiFeel(false);
	ac.setNight(false);
	ac.setEco(false);
	ac.setMax(false);
	ac.setFilter(false);
	ac.setLight(true);
	auto expected = std::vector<uint8_t>({
	0x0B, 0x36, 0x12, 0x0F, 0xC2, 0x24});
	auto actual = ac.getRaw();
	ASSERT_EQ(ac.getRawByteLength(), kArgo3AcControlStateLength);
	EXPECT_THAT(std::vector<uint8_t>(actual, actual + ac.getRawByteLength()),
	::testing::ElementsAreArray(expected));
	EXPECT_EQ(
	"Command[CH#0]: Model: 2 (WREM3), Power: On, Mode: 1 (Cool), Temp: 22C, "
	"Sensor Temp: 26C, Fan: 0 (Auto), Swing(V): 7 (Breeze), IFeel: Off, "
	"Night: Off, Econo: Off, Max: Off, Filter: Off, Light: On",
	ac.toString());
	}

[KingingWang]

Looks okay to me. It would be nice to have a unit test that confirms/shows this working the way it is expected to.

I have tested that it can normally control the wind speed of my air conditioner. But how should I write unit tests?

Capture what the real remote generates. i.e. the array code etc. for both cases. (for when quiet is on & off etc) and then use the library to construct the message using the functions/methods in the order etc you'd expect, and confirm that it produces the correct/same message.

e.g. Similar to this unit test in ir_Argo_test.cpp:

IRremoteESP8266/test/ir_Argo_test.cpp

Lines 121 to 147 in 5080851

	TEST(TestArgoAC_WREM3Class, MessageConstructon_ACControl) {
	IRArgoAC_WREM3 ac(kGpioUnused);
	ac.setChannel(0);
	ac.setPower(true);
	ac.setMode(argoMode_t::COOL);
	ac.setTemp(22);
	ac.setSensorTemp(26);
	ac.setFan(argoFan_t::FAN_AUTO);
	ac.setFlap(argoFlap_t::FLAP_FULL);
	ac.setiFeel(false);
	ac.setNight(false);
	ac.setEco(false);
	ac.setMax(false);
	ac.setFilter(false);
	ac.setLight(true);
	auto expected = std::vector<uint8_t>({
	0x0B, 0x36, 0x12, 0x0F, 0xC2, 0x24});
	auto actual = ac.getRaw();
	ASSERT_EQ(ac.getRawByteLength(), kArgo3AcControlStateLength);
	EXPECT_THAT(std::vector<uint8_t>(actual, actual + ac.getRawByteLength()),
	::testing::ElementsAreArray(expected));
	EXPECT_EQ(
	"Command[CH#0]: Model: 2 (WREM3), Power: On, Mode: 1 (Cool), Temp: 22C, "
	"Sensor Temp: 26C, Fan: 0 (Auto), Swing(V): 7 (Breeze), IFeel: Off, "
	"Night: Off, Econo: Off, Max: Off, Filter: Off, Light: On",
	ac.toString());
	}

Thank you for your reply. I will look into how the test code works later.