Fix python build on macOS#2267
Merged
Merged
Conversation
Assisted-by: Claude (Anthropic)
crankyoldgit
approved these changes
Jun 21, 2026
crankyoldgit
left a comment
Owner
There was a problem hiding this comment.
Awesome. Thanks for that.
Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes build issue for the python bindings added in #2067. On my MacBook Pro M1 running Tahoe 26.3.1 I got the following error when running
make.Note:
export CPLUS_INCLUDE_PATH="$( xcrun --show-sdk-path )/usr/include/c++/v1"is required before build.I have tested that the build, as well as
make testdockersucceeds.