Type mapper and sequence fixes#2
Open
hlcianfagna wants to merge 11 commits intocrate-workbench:cratedbfrom
Open
Type mapper and sequence fixes#2hlcianfagna wants to merge 11 commits intocrate-workbench:cratedbfrom
hlcianfagna wants to merge 11 commits intocrate-workbench:cratedbfrom
Conversation
This was referenced May 3, 2024
Look at this patch. Corresponding constraints also had to be relaxed, in this case private methods of Python, in order to be able to properly derive a CrateDB dialect from the existing PostgreSQL one, without needing to duplicate large swaths of code. |
|
Hi again. Apologies for the late reply. After GH-3 was resolved now, we validated this patch successfully on behalf of the TypeORM example application. Thank you Hernan! 💯 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
The CrateDB dialect for TypeORM needs a type mapper, and special treatments for the fact that primary autogenerated keys with CrateDB are UUIDs, stored as strings, as a workaround.
Details
The file
src/driver/cratedb/CrateDBPostgresQueryRunner.tshad to be copied into the tree as a whole, in order to be able to overwrite thebuildCreateColumnSqlmethod, because it is flagged asprotected.typeorm/src/driver/cratedb/CrateDBPostgresQueryRunner.ts
Lines 4602 to 4659 in 3f74136
References
It is based on basic work to unlock CrateDB with TypeORM.