Use bundled version of Ace editor config#604
Merged
Merged
Conversation
seut
reviewed
May 28, 2026
Comment on lines
+281
to
+283
| if (typeof ace === 'undefined') { | ||
| return undefined; | ||
| } |
Member
There was a problem hiding this comment.
Why not move this check before registerCrateDbMode to avoid checking typeof ace again?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fix the problem where Ace editor attempts to load a config definition from a separate file instead of using the one already bundled in the JavaScript code.
Checklist
CHANGES.md.