Add more tests

Author: surister

tests/client/test_connection.py

@@ -1,10 +1,12 @@
 import datetime
 from unittest.mock import MagicMock, patch
 
+import pytest
 from urllib3 import Timeout
 
 from crate.client import connect
 from crate.client.connection import Connection
+from crate.client.exceptions import ProgrammingError
 from crate.client.http import Client
 
 from .settings import crate_host
@@ -28,6 +30,37 @@ def test_lowest_server_version():
     assert (1, 0, 3) == connection.lowest_server_version.version
 
 
+
+def test_connection_closes_access():
+    """
+    Verify that a connection closes on exit and that it also closes
+    the client.
+    """
+    with patch('crate.client.connection.Client',
+               spec=Client,
+               return_value=MagicMock()) as client:
+
+        conn = connect()
+        conn.close()
+
+        assert conn._closed
+        client.assert_called_once()
+
+        # Should raise an exception if
+        # we try to access a cursor now.
+        with pytest.raises(ProgrammingError):
+            conn.cursor()
+
+        with pytest.raises(ProgrammingError):
+            conn.commit()
+
+def test_connection_closes_context_manager():
+    """Verify that the context manager of the client closes the connection"""
+    with patch.object(connect, 'close', autospec=True) as close_fn:
+        with connect():
+            pass
+        close_fn.assert_called_once()
+
 def test_invalid_server_version():
     """
     Verify that when no correct version is set,

tests/client/test_cursor.py

@@ -141,7 +141,6 @@ def test_execute_with_args(mocked_connection):
     cursor.execute(statement, 1)
     mocked_connection.client.sql.assert_called_once_with(statement, 1, None)
 
-
 def test_execute_with_bulk_args(mocked_connection):
     """
     Verify that `cursor.execute` is called with the right parameters
@@ -177,10 +176,9 @@ def test_execute_custom_converter(mocked_connection):
         "duration": 123,
     }
 
-    with mock.patch.object(
-            mocked_connection.client,
-            'sql',
-            return_value=response):
+    with mock.patch.object(mocked_connection.client,
+                           'sql',
+                           return_value=response):
         cursor.execute("")
         result = cursor.fetchall()
 
@@ -222,8 +220,7 @@ def test_execute_with_converter_and_invalid_data_type(mocked_connection):
     with mock.patch.object(
             mocked_connection.client,
             'sql',
-            return_value=response
-    ):
+            return_value=response):
         cursor.execute("")
         with pytest.raises(ValueError) as e:
             cursor.fetchone()
@@ -240,10 +237,9 @@ def test_execute_array_with_converter(mocked_connection):
         "rowcount": 1,
         "duration": 123,
     }
-    with mock.patch.object(
-            mocked_connection.client,
-            'sql',
-            return_value=response):
+    with mock.patch.object(mocked_connection.client,
+                           'sql',
+                           return_value=response):
         cursor.execute("")
         result = cursor.fetchone()