Reduce amount of versions tested in bwc tests

5.0/5.1 won't run anymore on systems using cgroups v2 due to a JDK bug:

    Caused by: java.lang.NullPointerException: Cannot invoke "jdk.internal.platform.CgroupInfo.getMountPoint()" because "any
    Controller" is null
            at jdk.internal.platform.cgroupv2.CgroupV2Subsystem.getInstance(CgroupV2Subsystem.java:80) ~[?:?]
            at jdk.internal.platform.CgroupSubsystemFactory.create(CgroupSubsystemFactory.java:114) ~[?:?]
            at jdk.internal.platform.CgroupMetrics.getInstance(CgroupMetrics.java:177) ~[?:?]
            at jdk.internal.platform.SystemMetrics.instance(SystemMetrics.java:29) ~[?:?]
            at jdk.internal.platform.Metrics.systemMetrics(Metrics.java:58) ~[?:?]
            at jdk.internal.platform.Container.metrics(Container.java:43) ~[?:?]

5.10 is already sort of EOL given that 6.2 is the current stable
release. So this also trims the 4-5 bwc tests given that it is unlikely
that we'll have anymore patches for 5.10 where storage changes or
serialization/mapping changes are relevant.

Author: mfussenegger

Jenkinsfile

@@ -23,7 +23,7 @@ pipeline {
             '''
           }
         }
-        stage('Python bwc-rolling-upgrade tests 4-5') {
+        stage('Python bwc-rolling-upgrade tests 5-5') {
           agent { label 'medium && x64' }
           tools { jdk 'jdk11' }
           steps {
@@ -34,7 +34,7 @@ pipeline {
               source .venv/bin/activate
               uv pip install -U -e .
 
-              (cd tests/bwc && python -m unittest -vvv test_rolling_upgrade.RollingUpgradeTest.test_rolling_upgrade_4_to_5)
+              (cd tests/bwc && python -m unittest -vvv test_rolling_upgrade.RollingUpgradeTest.test_rolling_upgrade_5_to_5)
             '''
           }
         }

src/crate/qa/tests.py

@@ -232,7 +232,10 @@ def upgrade_node(self, old_node: CrateNode, new_version: str) -> CrateNode:
         self._on_stop.remove(old_node)
         settings = getattr(old_node, "_settings", {})
         env = {}
-        if os.environ.get("DEBUGPY_RUNNING", "false") == "true":
+        crate_dir = get_crate(new_version)
+        version = _extract_version(crate_dir)
+        # 5,5 and 5,6 didn't bundle the jdwp module
+        if os.environ.get("DEBUGPY_RUNNING", "false") == "true" and (version < (5, 5, 0) or version >= (5, 7, 0)):
             jdwp = f"-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address={port}"
             env["CRATE_JAVA_OPTS"] = jdwp
         (new_node, _) = self._new_node(new_version, settings=settings, env=env)

tests/bwc/test_rolling_upgrade.py

@@ -7,34 +7,11 @@
 
 from crate.qa.tests import NodeProvider, insert_data, wait_for_active_shards, UpgradePath, assert_busy
 
-ROLLING_UPGRADES_V4 = (
-    # 4.0.0 -> 4.0.1 -> 4.0.2 don't support rolling upgrades due to a bug
-    UpgradePath('4.0.2', '4.0.x'),
-    UpgradePath('4.0.x', '4.1.0'),
-    UpgradePath('4.1.0', '4.1.x'),
-    UpgradePath('4.1.x', '4.2.x'),
-    UpgradePath('4.2.x', '4.3.x'),
-    UpgradePath('4.3.x', '4.4.x'),
-    UpgradePath('4.4.x', '4.5.x'),
-    UpgradePath('4.5.x', '4.6.x'),
-    UpgradePath('4.6.x', '4.7.x'),
-    UpgradePath('4.7.x', '4.8.x'),
-    UpgradePath('4.8.x', '5.0.x'),
-    UpgradePath('5.0.x', '5.1.x'),
-    UpgradePath('5.1.x', '5.2.x'),
-    UpgradePath('5.2.x', '5.3.x'),
-    UpgradePath('5.3.x', '5.4.x'),
-    UpgradePath('5.4.x', '5.5.x'),
-    UpgradePath('5.5.x', '5.6.x'),
-    UpgradePath('5.6.x', '5.7.x'),
-    UpgradePath('5.7.x', '5.8.x'),
-    UpgradePath('5.8.x', '5.9.x'),
-    UpgradePath('5.9.x', '5.10.x')
+ROLLING_UPGRADES_V5 = (
+    UpgradePath('5.9.x', '5.10.x'),
 )
 
-ROLLING_UPGRADES_V5 = (
-    UpgradePath('5.0.x', '5.1.x'),
-    UpgradePath('5.1.x', '5.2.x'),
+ROLLING_UPGRADES_V6 = (
     UpgradePath('5.2.x', '5.3.x'),
     UpgradePath('5.3.x', '5.4.x'),
     UpgradePath('5.4.x', '5.5.x'),
@@ -54,9 +31,9 @@
 
 class RollingUpgradeTest(NodeProvider, unittest.TestCase):
 
-    def test_rolling_upgrade_4_to_5(self):
+    def test_rolling_upgrade_5_to_5(self):
         print("")  # force newline for first print
-        for path in ROLLING_UPGRADES_V4:
+        for path in ROLLING_UPGRADES_V5:
             print(f"From {path.from_version}")
             with self.subTest(repr(path)):
                 try:
@@ -67,7 +44,7 @@ def test_rolling_upgrade_4_to_5(self):
 
     def test_rolling_upgrade_5_to_6(self):
         print("")  # force newline for first print
-        for path in ROLLING_UPGRADES_V5:
+        for path in ROLLING_UPGRADES_V6:
             print(f"From {path.from_version}")
             with self.subTest(repr(path)):
                 try:

tests/bwc/test_upgrade.py

@@ -25,17 +25,6 @@
 
 UPGRADE_PATHS = (
     (
-        VersionDef('4.0.x', []),
-        VersionDef('4.1.x', []),
-        VersionDef('4.2.x', []),
-        VersionDef('4.3.x', []),
-        VersionDef('4.4.x', []),
-        VersionDef('4.5.x', []),
-        VersionDef('4.6.x', []),
-        VersionDef('4.7.x', []),
-        VersionDef('4.8.x', []),
-        VersionDef('5.0.x', []),
-        VersionDef('5.1.x', []),
         VersionDef('5.2.x', []),
         VersionDef('5.3.x', []),
         VersionDef('5.4.x', []),
@@ -47,8 +36,6 @@
         VersionDef('5.10.x', []),
     ),
     (
-        VersionDef('5.0.x', []),
-        VersionDef('5.1.x', []),
         VersionDef('5.2.x', []),
         VersionDef('5.3.x', []),
         VersionDef('5.4.x', []),