I/O: Migrate Kafka->CrateDB recipe from ingestr to omniload#1842
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
b3d19cd to
4d7d765
Compare
| @@ -1 +0,0 @@ | |||
| ingestr @ git+https://github.com/crate-workbench/ingestr.git@kafka-decoder | |||
There was a problem hiding this comment.
This custom repository reference has been dissolved now. 👍
All what is needed here is packaged into omniload v0.2 today. 🌻
florinutz
left a comment
There was a problem hiding this comment.
so basically we're moving away from ingestr, towards omniload, right?
|
Hi Florin, in CrateDB Toolkit, this other patch moves away from ingestr, mainly due to licensing concerns. Here, we are just migrating one exercise from ingestr to omniload, but both ETL applications will continue to have their representation within
With kind regards, |
4d7d765 to
8ab01c1
Compare
ingestr v1 migrated to Go, but omniload inherited the Python codebase. It also integrated the long-awaited pending patch to improve the Kafka decoder, so everything we need to transfer data from Kafka to CrateDB is nicely wrapped into a package going forward.
8ab01c1 to
f24449e
Compare
About
ingestr v1 migrated to Go, but omniload inherited the v0 codebase based on dlt and Python. It also integrated the long-awaited pending patch to improve the Kafka decoder, so everything we need to transfer data from Kafka to CrateDB is now nicely wrapped into a package going forward.
Review
This patch mostly includes a refactoring and renaming operation
s/ingestr/omniload/for one particular data i/o nozzle exercise that transfers data from a Kafka topic into a CrateDB table, which needs some more advanced transformations than the standard data path would provide.Other than the layout refactoring by extracting the kafka-to-cratedb exercise into the
application/omniloadfolder, no other changes were made to the database workload or validation code:kafka-compose.ymlandkafka-demo.xshwere moved to the new folder almost unmodified.References
default_msg_processorinto a miniature decoding unit panodata/omniload#51/cc @florinutz, @matriv