Types: Improve type mapping for SQLAlchemy upper-case type aliases

Author: amotl

cratedb_fivetran_destination/engine.py

@@ -116,14 +116,14 @@ def to_sql(self) -> SqlBag:
             column_name_temporary = column_name + "_alter_tmp"
             type_ = TypeMap.to_cratedb(column.type, column.params)
             sqlbag.add(
-                f"ALTER TABLE {self.table.fullname} ADD COLUMN {column_name_temporary} {type_};"
+                f'ALTER TABLE {self.table.fullname} ADD COLUMN "{column_name_temporary}" {type_};'
             )
             sqlbag.add(
-                f"UPDATE {self.table.fullname} SET {column_name_temporary} = {column_name}::{type_};"  # noqa: S608, E501
+                f'UPDATE {self.table.fullname} SET "{column_name_temporary}" = "{column_name}"::{type_};'  # noqa: S608, E501
             )
-            sqlbag.add(f"ALTER TABLE {self.table.fullname} DROP {column_name};")
+            sqlbag.add(f'ALTER TABLE {self.table.fullname} DROP "{column_name}";')
             sqlbag.add(
-                f"ALTER TABLE {self.table.fullname} RENAME {column_name_temporary} TO {column_name};"  # noqa: E501
+                f'ALTER TABLE {self.table.fullname} RENAME "{column_name_temporary}" TO "{column_name}";'  # noqa: E501
             )
 
         # Translate "new column" instructions into `ALTER TABLE ... ADD ...` clauses.

cratedb_fivetran_destination/model.py

@@ -79,20 +79,32 @@ class TypeMap:
     }
 
     cratedb_map = {
-        sa.String: DataType.STRING,
         sa.Text: DataType.STRING,
+        sa.TEXT: DataType.STRING,
+        sa.VARCHAR: DataType.STRING,
         sa.Boolean: DataType.BOOLEAN,
+        sa.BOOLEAN: DataType.BOOLEAN,
         sa.SmallInteger: DataType.SHORT,
         sa.Integer: DataType.INT,
         sa.BigInteger: DataType.LONG,
+        sa.SMALLINT: DataType.SHORT,
+        sa.INTEGER: DataType.INT,
+        sa.BIGINT: DataType.LONG,
         sa.Float: DataType.FLOAT,
+        sa.FLOAT: DataType.FLOAT,
         sa.Double: DataType.DOUBLE,
+        sa.DOUBLE: DataType.DOUBLE,
+        sa.DOUBLE_PRECISION: DataType.DOUBLE,
         sa.Date: DataType.NAIVE_DATE,
+        sa.DATE: DataType.NAIVE_DATE,
         # FIXME: Which one to choose?
         #        Need better inspection about aware/unaware datetime objects?
         # sa.DateTime: DataType.NAIVE_DATETIME,
         sa.DateTime: DataType.UTC_DATETIME,
+        sa.DATETIME: DataType.UTC_DATETIME,
+        sa.Numeric: DataType.DECIMAL,
         sa.DECIMAL: DataType.DECIMAL,
+        sa.LargeBinary: DataType.BINARY,
         sa.BINARY: DataType.BINARY,
         ObjectType: DataType.JSON,
         # FIXME: What about Arrays?

docs/backlog.md

@@ -1,6 +1,7 @@
 # Backlog
 
 ## Iteration +1
+- Does `SELECT '100.23'::BIGINT;` work on PostgreSQL?
 - Introduce parameter handling to type mappers,
   re. timestamp and decimal types
 - AlterTable: Implement `AlterTableRecreateStatements`