Merge SA 2.1 compat into core20.py, supporting both SA 2.0 and 2.1#254
Merge SA 2.1 compat into core20.py, supporting both SA 2.0 and 2.1#254kneth wants to merge 1 commit intokneth/sqlalchemy-21-compatibilityfrom
Conversation
Consolidate `core21.py` into `core20.py` by guarding the three SA 2.1-specific differences behind `SA_VERSION >= SA_2_1` checks: - `visiting_cte` parameter and `toplevel` logic in `visit_update` - `update_post_criteria_clause` (renamed from `update_limit_clause`) - removal of the `_ordered_values` branch in `_get_crud_params` Delete `core21.py` and simplify the dialect dispatch to always use `CrateCompilerSA20` for SA >= 2.0. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use Trivy to scan for security misconfigurations and secrets in Infrastructure as Code files.Add a .trivyignore file to your project to customize which findings Trivy reports. |
There was a problem hiding this comment.
Hi Kenneth. @mfussenegger agreed on this at #253 (comment). Can you integrate it into the other PR if you are also convinced this is the right solution?
Please let us know about any concerns. If @matriv has a minute, he might also have a look. Otherwise, please proceed. 🙏
3 participants
Summary of the changes / Why this is an improvement
A commit in response to #253 (comment)
Checklist
Link to issue this PR refers to (if applicable): Fixes #???