Skip to content

Commit 4e67c63

Browse files
committed
add note to sharedExtensionCheck
1 parent f556f37 commit 4e67c63

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

src/SPC/builder/Extension.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,13 +187,17 @@ public function patchBeforeMake(): bool
187187

188188
/**
189189
* Run shared extension check when cli is enabled
190+
* @throws RuntimeException
190191
*/
191192
public function runSharedExtensionCheckUnix(): void
192193
{
193194
[$ret] = shell()->execWithResult(BUILD_BIN_PATH . '/php -n -d "extension=' . BUILD_LIB_PATH . '/' . $this->getName() . '.so" --ri ' . $this->getName());
194195
if ($ret !== 0) {
195196
throw new RuntimeException($this->getName() . '.so failed to load');
196197
}
198+
if ($this->isBuildStatic()) {
199+
logger()->warning($this->getName() . '.so test succeeded, but has little significance since it is also compiled in statically.');
200+
}
197201
}
198202

199203
/**

0 commit comments

Comments
 (0)