Improve zlib Windows library detection: add libz.lib candidate, error on missing lib, safe cleanup

The existing detection list misses `libz.lib` which zlib 1.3.3+ may produce.
This adds it as a fourth candidate and throws a clear RuntimeException when
no known static library is found, instead of silently continuing with a
broken build.

Also ensures shared-lib cleanup skips whichever file was detected as the
static library, and looks for DLLs in the correct bin/ directory.

Author: Hendrik Mennen

src/SPC/builder/windows/library/zlib.php

@@ -31,23 +31,39 @@ protected function build(): void
                 $this->builder->makeSimpleWrapper('cmake'),
                 "--build build --config Release --target install -j{$this->builder->concurrency}"
             );
+        // zlib >=1.3.2 changed output names (zlibstatic.lib -> zs.lib),
+        // and 1.3.3+ may use libz.lib. Detect whichever exists and
+        // normalize to the names PHP and other consumers expect.
         $detect_list = [
             'zlibstatic.lib',
             'zs.lib',
             'libzs.lib',
+            'libz.lib',
         ];
+        $found = null;
         foreach ($detect_list as $item) {
             if (file_exists(BUILD_LIB_PATH . '\\' . $item)) {
-                FileSystem::copy(BUILD_LIB_PATH . '\\' . $item, BUILD_LIB_PATH . '\zlib_a.lib');
-                FileSystem::copy(BUILD_LIB_PATH . '\\' . $item, BUILD_LIB_PATH . '\zlibstatic.lib');
+                $found = $item;
                 break;
             }
         }
+        if ($found === null) {
+            throw new \RuntimeException('zlib build produced no known static library. Looked for: ' . implode(', ', $detect_list));
+        }
+        FileSystem::copy(BUILD_LIB_PATH . '\\' . $found, BUILD_LIB_PATH . '\zlib_a.lib');
+        if ($found !== 'zlibstatic.lib') {
+            FileSystem::copy(BUILD_LIB_PATH . '\\' . $found, BUILD_LIB_PATH . '\zlibstatic.lib');
+        }
+
+        // Clean up shared lib artifacts
         FileSystem::removeFileIfExists(BUILD_ROOT_PATH . '\bin\zlib.dll');
-        FileSystem::removeFileIfExists(BUILD_LIB_PATH . '\zlib.lib');
-        FileSystem::removeFileIfExists(BUILD_LIB_PATH . '\libz.dll');
-        FileSystem::removeFileIfExists(BUILD_LIB_PATH . '\libz.lib');
-        FileSystem::removeFileIfExists(BUILD_LIB_PATH . '\z.lib');
-        FileSystem::removeFileIfExists(BUILD_LIB_PATH . '\z.dll');
+        FileSystem::removeFileIfExists(BUILD_ROOT_PATH . '\bin\z.dll');
+        FileSystem::removeFileIfExists(BUILD_ROOT_PATH . '\bin\libz.dll');
+        foreach (['zlib.lib', 'z.lib', 'libz.lib'] as $implib) {
+            $path = BUILD_LIB_PATH . '\\' . $implib;
+            if ($implib !== $found) {
+                FileSystem::removeFileIfExists($path);
+            }
+        }
     }
 }