Skip to content

Better exception#760

Merged
henderkes merged 2 commits into
crazywhalecc:mainfrom
lyrixx:better-exception
Jun 12, 2025
Merged

Better exception#760
henderkes merged 2 commits into
crazywhalecc:mainfrom
lyrixx:better-exception

Conversation

@lyrixx

@lyrixx lyrixx commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

refs : #759

@lyrixx

lyrixx commented Jun 11, 2025

Copy link
Copy Markdown
Contributor Author

Side note : I noticed you "implemented" your own logging system, http client, process runner.
I think it would have been better to rely more on symfony.
For example, I run the command -vvv to get all logs. But it didn't work since I had to use --debug.
Another exemple is the process handler, We could have much more information when a process failed

@henderkes

Copy link
Copy Markdown
Collaborator

That's a great idea, we will tackle it later.

@crazywhalecc crazywhalecc left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have plans to refactor the error log output to be more useful, but it will take time. For now I have included -v as a compatibility parameter that has the same effect as --debug.

@henderkes henderkes merged commit bb0a358 into crazywhalecc:main Jun 12, 2025
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants