Fix sonarqube findings

Dockerfile

@@ -1,22 +1,17 @@
-# Use the continuumio/anaconda3 image as a base
-# https://hub.docker.com/r/continuumio/anaconda3
-FROM continuumio/anaconda3:latest
+FROM python:3.12
 
 # Creare maintained
-MAINTAINER Creare podpac@creare.com
+LABEL org.opencontainers.image.authors="podpac@creare.com"
 
 # Install general tools
 RUN apt-get update --yes --quiet && apt-get install --yes --quiet --no-install-recommends \
     build-essential \ 
     curl \ 
     unzip \
     tar \
-    wget
-
-# Create a podpac anaconda environment and activate
-RUN conda init bash && . ~/.bashrc \
-    && conda create --yes --name podpac python=3 anaconda \
-    && conda activate podpac
-
+    wget && \
+    apt-get clean
+COPY . /opt/podpac
+WORKDIR /opt/podpac
 # Install PODPAC with all dependencies
-RUN pip install podpac[all]
+RUN pip install .[all]

doc/source/conf.py

@@ -20,8 +20,6 @@
 import os
 from shutil import copyfile
 
-# import sys
-# sys.path.insert(0, os.path.abspath('.'))
 import datetime
 
 # for parsing markdown files

podpac/__init__.py

@@ -22,9 +22,7 @@ def makedirs(name, mode=511, exist_ok=False):
     try:
         _osmakedirs(name, mode)
     except OSError as e:
-        if exist_ok:
-            pass
-        else:
+        if not exist_ok:
             raise e
 
 

podpac/core/__init__.py

@@ -22,4 +22,3 @@ def lazy_module(modname, *args, **kwargs):
 plt = lazy_import.lazy_module("matplotlib.pyplot")
 np = lazy_import.lazy_module("numpy")
 tl = lazy_import.lazy_module("traitlets")
-# xr = lazy_import.lazy_module("xarray")

podpac/core/algorithm/stats.py

@@ -575,15 +575,6 @@ def reduce(self, x):
         UnitsDataArray
             Skew of the source data over dims
         """
-        # N = np.isfinite(x).sum(dim=self._dims)
-        # M1 = x.mean(dim=self._dims)
-        # E = x - M1
-        # E2 = E**2
-        # E3 = E2*E
-        # M2 = (E2).sum(dim=self._dims)
-        # M3 = (E3).sum(dim=self._dims)
-        # skew = self.skew(M3, M2, N)
-
         a = self._reshape(x)
         skew = scipy.stats.skew(a, nan_policy="omit")
         return skew
@@ -660,15 +651,6 @@ def reduce(self, x):
         UnitsDataArray
             Kurtosis of the source data over dims
         """
-        # N = np.isfinite(x).sum(dim=self._dims)
-        # M1 = x.mean(dim=self._dims)
-        # E = x - M1
-        # E2 = E**2
-        # E4 = E2**2
-        # M2 = (E2).sum(dim=self._dims)
-        # M4 = (E4).sum(dim=self._dims)
-        # kurtosis = N * M4 / M2**2 - 3
-
         a = self._reshape(x)
         kurtosis = scipy.stats.kurtosis(a, nan_policy="omit")
         return kurtosis
@@ -910,12 +892,6 @@ def _eval(self, coordinates, output=None, _selector=None):
         else:
             output.data[:] = out.data[:]
 
-        ## map
-        # eval_time = xr.DataArray(coordinates.coords["time"])
-        # E = getattr(eval_time.dt, self.groupby)
-        # out = out.sel(**{self.groupby: E}).rename({self.groupby: "time"})
-        # output[:] = out.transpose(*output.dims).data
-
         return output
 
     @tl.default("base_ref")
@@ -1002,12 +978,6 @@ def _eval(self, coordinates, output=None, _selector=None):
         else:
             output.data[:] = out.data[:]
 
-        ## map
-        # eval_time = xr.DataArray(coordinates.coords["time"])
-        # E = getattr(eval_time.dt, self.groupby)
-        # out = out.sel(**{self.groupby: E}).rename({self.groupby: "time"})
-        # output[:] = out.transpose(*output.dims).data
-
         return output
 
     @tl.default("base_ref")

podpac/core/cache/s3_cache_store.py

@@ -50,7 +50,6 @@ def __init__(self, s3_bucket=None, aws_region_name=None, aws_access_key_id=None,
         aws_session = boto3.session.Session(region_name=aws_region_name)
         self._s3_client = aws_session.client(
             "s3",
-            # config= boto3.session.Config(signature_version='s3v4'),
             aws_access_key_id=aws_access_key_id,
             aws_secret_access_key=aws_secret_access_key,
         )

podpac/core/compositor/test/test_base_compositor.py

@@ -46,33 +46,33 @@ def test_source_coordinates(self):
         assert node.source_coordinates is None
 
         # unstacked
-        node = BaseCompositor(
+        BaseCompositor(
             sources=[podpac.algorithm.Arange(), podpac.algorithm.SinCoords()],
             source_coordinates=podpac.Coordinates([[0, 1]], dims=["time"]),
         )
 
         # stacked
-        node = BaseCompositor(
+        BaseCompositor(
             sources=[podpac.algorithm.Arange(), podpac.algorithm.SinCoords()],
             source_coordinates=podpac.Coordinates([[[0, 1], [10, 20]]], dims=["time_alt"]),
         )
 
         # invalid size
         with pytest.raises(ValueError, match="Invalid source_coordinates, source and source_coordinates size mismatch"):
-            node = BaseCompositor(
+            BaseCompositor(
                 sources=[podpac.algorithm.Arange(), podpac.algorithm.SinCoords()],
                 source_coordinates=podpac.Coordinates([[0, 1, 2]], dims=["time"]),
             )
 
         with pytest.raises(ValueError, match="Invalid source_coordinates, source and source_coordinates size mismatch"):
-            node = BaseCompositor(
+            BaseCompositor(
                 sources=[podpac.algorithm.Arange(), podpac.algorithm.SinCoords()],
                 source_coordinates=podpac.Coordinates([[0, 1, 2]], dims=["time"]),
             )
 
         # invalid ndims
         with pytest.raises(ValueError, match="Invalid source_coordinates"):
-            node = BaseCompositor(
+            BaseCompositor(
                 sources=[podpac.algorithm.Arange(), podpac.algorithm.SinCoords()],
                 source_coordinates=podpac.Coordinates([[0, 1], [10, 20]], dims=["time", "alt"]),
             )
@@ -252,7 +252,7 @@ def test_auto_outputs(self):
 
         # mixed
         with pytest.raises(ValueError, match="Cannot composite standard sources with multi-output sources."):
-            node = BaseCompositor(sources=[MULTI_2_X, ARRAY_LAT], auto_outputs=True)
+            BaseCompositor(sources=[MULTI_2_X, ARRAY_LAT], auto_outputs=True)
 
         # no sources
         node = BaseCompositor(sources=[], auto_outputs=True)

podpac/core/coordinates/array_coordinates1d.py

@@ -62,18 +62,15 @@ def __init__(self, coordinates, name=None, **kwargs):
         self.not_a_trait = coordinates
 
         # precalculate once
-        if self.coordinates.size == 0:
-            pass
-
-        elif self.coordinates.size == 1:
+        if self.coordinates.size == 1:
             self._is_monotonic = True
 
         elif self.coordinates.ndim > 1:
             self._is_monotonic = None
             self._is_descending = None
             self._is_uniform = None
 
-        else:
+        elif self.coordinates.size != 0:
             deltas = self.deltas
             if np.any(deltas <= 0):
                 self._is_monotonic = False

podpac/core/coordinates/coordinates.py

@@ -653,14 +653,13 @@ def __getitem__(self, index):
 
     def __setitem__(self, dim, c):
         # coerce
-        if isinstance(c, BaseCoordinates):
-            pass
-        elif isinstance(c, Coordinates):
-            c = c[dim]
-        elif "_" in dim:
-            c = StackedCoordinates(c)
-        else:
-            c = ArrayCoordinates1d(c)
+        if not isinstance(c, BaseCoordinates):
+            if isinstance(c, Coordinates):
+                c = c[dim]
+            elif "_" in dim:
+                c = StackedCoordinates(c)
+            else:
+                c = ArrayCoordinates1d(c)
 
         c._set_name(dim)
 
@@ -937,7 +936,6 @@ def geotransform(self):
                 "{} do not.".format(self)
             )
         if self.udims.index("lon") < self.udims.index("lat"):
-            # transform = (transform[3], transform[5], transform[4], transform[0], transform[2], transform[1])
             transform = transform[3:] + transform[:3]
 
         return transform

podpac/core/coordinates/polar_coordinates.py

@@ -197,17 +197,3 @@ def full_definition(self):
 
     def copy(self):
         return PolarCoordinates(self.center, self.radius, self.theta, dims=self.dims)
-
-    # TODO return PolarCoordinates when possible
-    # def select(self, other, outer=False):
-    #     raise NotImplementedError("TODO")
-
-    # ------------------------------------------------------------------------------------------------------------------
-    # Debug
-    # ------------------------------------------------------------------------------------------------------------------
-
-    # def plot(self, marker='b.', center_marker='bx'):
-    #     from matplotlib import pyplot
-    #     super(PolarCoordinates, self).plot(marker=marker)
-    #     cx, cy = self.center
-    #     pyplot.plot(cx, cy, center_marker)