clean-up path handling (use os.path.join and remove unnecessary f-strings)

Author: TimidRobot

google_custom_search/google_scratcher.py

@@ -40,17 +40,17 @@
 # Set up file path for CSV report
 DATA_WRITE_FILE = os.path.join(
     PATH_WORK_DIR,
-    f"/data_google_custom_search_"
+    "data_google_custom_search_"
     f"{DATETIME_TODAY.year}_{DATETIME_TODAY.month}_{DATETIME_TODAY.day}.csv",
 )
 DATA_WRITE_FILE_TIME = os.path.join(
     PATH_WORK_DIR,
-    f"/data_google_custom_search_time_"
+    "data_google_custom_search_time_"
     f"{DATETIME_TODAY.year}_{DATETIME_TODAY.month}_{DATETIME_TODAY.day}.csv",
 )
 DATA_WRITE_FILE_COUNTRY = os.path.join(
     PATH_WORK_DIR,
-    f"/data_google_custom_search_country_"
+    "data_google_custom_search_country_"
     f"{DATETIME_TODAY.year}_{DATETIME_TODAY.month}_{DATETIME_TODAY.day}.csv",
 )
 
@@ -69,7 +69,7 @@ def get_license_list():
     """
     # Read license data from file
     cc_license_data = pd.read_csv(
-        f"{PATH_REPO_ROOT}/legal-tool-paths.txt", header=None
+        os.path.join(PATH_REPO_ROOT, "legal-tool-paths.txt"), header=None
     )
     # Define regex pattern to extract license types
     license_pattern = r"((?:[^/]+/){2}(?:[^/]+)).*"
@@ -97,7 +97,7 @@ def get_lang_list():
     )
 
     languages = pd.read_csv(
-        f"{PATH_WORK_DIR}/google_lang.txt",
+        os.path.join(PATH_WORK_DIR, "google_lang.txt"),
         sep=": ",
         header=None,
         engine="python",

internetarchive/internetarchive_scratcher.py

@@ -28,7 +28,7 @@
 # Set up file path for CSV report
 DATA_WRITE_FILE = os.path.join(
     PATH_WORK_DIR,
-    f"/data_internetarchive_"
+    "data_internetarchive_"
     f"{DATETIME_TODAY.year}_{DATETIME_TODAY.month}_{DATETIME_TODAY.day}.csv",
 )
 
@@ -47,7 +47,7 @@ def get_license_list():
     """
     # Read license data from file
     cc_license_data = pd.read_csv(
-        f"{PATH_REPO_ROOT}/legal-tool-paths.txt", header=None
+        os.path.join(PATH_REPO_ROOT, "legal-tool-paths.txt"), header=None
     )
     # Define regex pattern to extract license types
     license_pattern = r"((?:[^/]+/){2}(?:[^/]+)).*"

metmuseum/metmuseum_scratcher.py

@@ -24,7 +24,7 @@
 # Set up file path for CSV report
 DATA_WRITE_FILE = os.path.join(
     PATH_WORK_DIR,
-    f"/data_metmuseum_"
+    "data_metmuseum_"
     f"{DATETIME_TODAY.year}_{DATETIME_TODAY.month}_{DATETIME_TODAY.day}.csv",
 )
 

vimeo/vimeo_scratcher.py

@@ -36,7 +36,7 @@
 # Set up file path for CSV report
 DATA_WRITE_FILE = os.path.join(
     PATH_WORK_DIR,
-    f"/data_vimeo_"
+    "data_vimeo_"
     f"{DATETIME_TODAY.year}_{DATETIME_TODAY.month}_{DATETIME_TODAY.day}.csv",
 )
 

wikicommons/wikicommons_scratcher.py

@@ -23,7 +23,7 @@
 # Set up file path for CSV report
 DATA_WRITE_FILE = os.path.join(
     PATH_WORK_DIR,
-    f"/data_wikicommons_"
+    "data_wikicommons_"
     f"{DATETIME_TODAY.year}_{DATETIME_TODAY.month}_{DATETIME_TODAY.day}.csv",
 )
 

wikipedia/wikipedia_scratcher.py

@@ -23,7 +23,7 @@
 # Set up file path for CSV report
 DATA_WRITE_FILE = os.path.join(
     PATH_WORK_DIR,
-    f"/data_wikipedia_"
+    "data_wikipedia_"
     f"{DATETIME_TODAY.year}_{DATETIME_TODAY.month}_{DATETIME_TODAY.day}.csv",
 )
 

youtube/youtube_scratcher.py

@@ -33,12 +33,12 @@
 # Set up file path for CSV report
 DATA_WRITE_FILE = os.path.join(
     PATH_WORK_DIR,
-    f"/data_youtube_"
+    "data_youtube_"
     f"{DATETIME_TODAY.year}_{DATETIME_TODAY.month}_{DATETIME_TODAY.day}.csv",
 )
 DATA_WRITE_FILE_TIME = os.path.join(
     PATH_WORK_DIR,
-    f"/data_youtube_time_"
+    "data_youtube_time_"
     f"{DATETIME_TODAY.year}_{DATETIME_TODAY.month}_{DATETIME_TODAY.day}.csv",
 )