Made review changes

Author: oree-xx

scripts/3-report/gcs_report.py

@@ -36,6 +36,7 @@ def parse_arguments():
     """
     Parses command-line arguments, returns parsed arguments.
     """
+    global QUARTER
     LOGGER.info("Parsing command-line arguments")
     parser = argparse.ArgumentParser(description=__doc__)
     parser.add_argument(
@@ -68,7 +69,7 @@ def parse_arguments():
     if not args.enable_save and args.enable_git:
         parser.error("--enable-git requires --enable-save")
     if args.quarter != QUARTER:
-        global PATHS, QUARTER
+        global PATHS
         PATHS = shared.paths_update(LOGGER, PATHS, QUARTER, args.quarter)
         QUARTER = args.quarter
     args.logger = LOGGER
@@ -497,8 +498,8 @@ def main():
     args = parse_arguments()
     shared.paths_log(LOGGER, PATHS)
     shared.git_fetch_and_merge(args, PATHS["repo"])
-    LAST_ENTRY = shared.path_join(PATHS["data_phase"], "gcs_free_culture.png")
-    shared.check_completion_file_exists(args, LAST_ENTRY)
+    last_entry = shared.path_join(PATHS["data_phase"], "gcs_free_culture.png")
+    shared.check_completion_file_exists(args, last_entry)
     gcs_intro(args)
     plot_products(args)
     plot_tool_status(args)

scripts/3-report/github_report.py

@@ -34,6 +34,7 @@ def parse_arguments():
     """
     Parses command-line arguments, returns parsed arguments.
     """
+    global QUARTER
     LOGGER.info("Parsing command-line arguments")
     parser = argparse.ArgumentParser(description=__doc__)
     parser.add_argument(
@@ -66,7 +67,7 @@ def parse_arguments():
     if not args.enable_save and args.enable_git:
         parser.error("--enable-git requires --enable-save")
     if args.quarter != QUARTER:
-        global PATHS, QUARTER
+        global PATHS
         PATHS = shared.paths_update(LOGGER, PATHS, QUARTER, args.quarter)
         QUARTER = args.quarter
     args.logger = LOGGER
@@ -244,10 +245,10 @@ def main():
     args = parse_arguments()
     shared.paths_log(LOGGER, PATHS)
     shared.git_fetch_and_merge(args, PATHS["repo"])
-    LAST_ENTRY = shared.path_join(
+    last_entry = shared.path_join(
         PATHS["data_phase"], "github_restriction.png"
     )
-    shared.check_completion_file_exists(args, LAST_ENTRY)
+    shared.check_completion_file_exists(args, last_entry)
     github_intro(args)
     plot_totals_by_license_type(args)
     plot_totals_by_restriction(args)

scripts/3-report/wikipedia_report.py

@@ -34,6 +34,7 @@ def parse_arguments():
     """
     Parses command-line arguments, returns parsed arguments.
     """
+    global QUARTER
     LOGGER.info("Parsing command-line arguments")
     parser = argparse.ArgumentParser(description=__doc__)
     parser.add_argument(
@@ -66,7 +67,7 @@ def parse_arguments():
     if not args.enable_save and args.enable_git:
         parser.error("--enable-git requires --enable-save")
     if args.quarter != QUARTER:
-        global PATHS, QUARTER
+        global PATHS
         PATHS = shared.paths_update(LOGGER, PATHS, QUARTER, args.quarter)
         QUARTER = args.quarter
     args.logger = LOGGER
@@ -267,10 +268,10 @@ def main():
     args = parse_arguments()
     shared.paths_log(LOGGER, PATHS)
     shared.git_fetch_and_merge(args, PATHS["repo"])
-    LAST_ENTRY = shared.path_join(
+    last_entry = shared.path_join(
         PATHS["data_phase"], "wikipedia_least_language_usage.png"
     )
-    shared.check_completion_file_exists(args, LAST_ENTRY)
+    shared.check_completion_file_exists(args, last_entry)
     wikipedia_intro(args)
     plot_language_representation(args)
     plot_highest_language_usage(args)