detect_test.go

package selfupdate

import (
	"context"
	"fmt"
	stdlog "log"
	"os"
	"strconv"
	"strings"
	"testing"

	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/require"
)

var (
	testGithubRepository = NewRepositorySlug("creativeprojects", "resticprofile")
)

func skipRateLimitExceeded(t *testing.T, err error) {
	if err == nil {
		return
	}
	if strings.Contains(err.Error(), "403 API rate limit") {
		t.Skip("Test skipped because of GitHub API rate limit exceeded")
	}
}

func TestDetectReleaseWithVersionPrefix(t *testing.T) {
	testData := []struct {
		run     bool
		name    string
		updater *Updater
	}{
		{true, "Mock", newMockUpdater(t, Config{Source: mockSourceRepository(t)})},
		{!testing.Short(), "GitHub", DefaultUpdater()},
	}

	for _, testItem := range testData {
		if !testItem.run {
			continue
		}
		t.Run(testItem.name, func(t *testing.T) {
			r, ok, err := testItem.updater.DetectLatest(context.Background(), testGithubRepository)
			skipRateLimitExceeded(t, err)
			require.NoError(t, err)
			assert.True(t, ok, "Failed to detect latest")
			require.NotNil(t, r, "No release returned")
			if r.LessThan("0.14.0") {
				t.Error("Incorrect version:", r.Version())
			}
			if !strings.HasSuffix(r.AssetURL, ".zip") && !strings.HasSuffix(r.AssetURL, ".tar.gz") {
				t.Error("Incorrect URL for asset:", r.AssetURL)
			}
			assert.NotEmpty(t, r.URL, "Document URL should not be empty")
			assert.NotEmpty(t, r.ReleaseNotes, "Description should not be empty for this repo")
			assert.NotEmpty(t, r.Name, "Release name is unexpectedly empty")
			assert.NotEmpty(t, r.AssetByteSize, "Asset's size is unexpectedly zero")
			assert.NotEmpty(t, r.AssetID, "Asset's ID is unexpectedly zero")
			assert.NotZero(t, r.PublishedAt, "Release time is unexpectedly zero")
		})
	}
}

func TestDetectVersionExisting(t *testing.T) {
	testVersion := "v0.14.0"
	gitHub, _ := NewUpdater(Config{Validator: &ChecksumValidator{UniqueFilename: "checksums.txt"}})
	testData := []struct {
		run     bool
		name    string
		updater *Updater
	}{
		{true, "Mock", newMockUpdater(t, Config{Source: mockSourceRepository(t), Validator: &ChecksumValidator{UniqueFilename: "checksums.txt"}})},
		{!testing.Short(), "GitHub", gitHub},
	}

	for _, testItem := range testData {
		if !testItem.run {
			continue
		}
		t.Run(testItem.name, func(t *testing.T) {
			r, ok, err := testItem.updater.DetectVersion(context.Background(), testGithubRepository, testVersion)
			skipRateLimitExceeded(t, err)
			require.NoError(t, err)
			assert.Truef(t, ok, "Failed to detect %s", testVersion)
			require.NotNil(t, r, "No release returned")
			assert.Greater(t, r.ValidationAssetID, int64(-1))
		})
	}
}

func TestDetectVersionExistingWithNoValidationFile(t *testing.T) {
	testVersion := "v0.14.0"
	gitHub, _ := NewUpdater(Config{Validator: &ChecksumValidator{UniqueFilename: "notfound.txt"}})
	testData := []struct {
		run     bool
		name    string
		updater *Updater
	}{
		{true, "Mock", newMockUpdater(t, Config{Source: mockSourceRepository(t), Validator: &ChecksumValidator{UniqueFilename: "notfound.txt"}})},
		{!testing.Short(), "GitHub", gitHub},
	}

	for _, testItem := range testData {
		if !testItem.run {
			continue
		}
		t.Run(testItem.name, func(t *testing.T) {
			_, _, err := testItem.updater.DetectVersion(context.Background(), testGithubRepository, testVersion)
			skipRateLimitExceeded(t, err)
			assert.ErrorIs(t, err, ErrValidationAssetNotFound)
		})
	}
}

func TestDetectVersionNotExisting(t *testing.T) {
	testData := []struct {
		run     bool
		name    string
		updater *Updater
	}{
		{true, "Mock", newMockUpdater(t, Config{Source: mockSourceRepository(t)})},
		{!testing.Short(), "GitHub", DefaultUpdater()},
	}

	for _, testItem := range testData {
		if !testItem.run {
			continue
		}
		t.Run(testItem.name, func(t *testing.T) {
			r, ok, err := testItem.updater.DetectVersion(context.Background(), testGithubRepository, "foobar")
			skipRateLimitExceeded(t, err)
			require.NoError(t, err)
			assert.False(t, ok, "Failed to correctly detect foobar")
			assert.Nil(t, r, "Release not detected but got a returned value for it")
		})
	}
}

func TestDetectPrerelease(t *testing.T) {
	testFixtures := []struct {
		prerelease bool
		version    string
	}{
		{false, "1.0.0"},
		{true, "2.0.0-beta"},
	}
	for _, testFixture := range testFixtures {
		t.Run(strconv.FormatBool(testFixture.prerelease), func(t *testing.T) {
			updater := newMockUpdater(t, Config{
				Source:     mockSourceRepository(t),
				Prerelease: testFixture.prerelease,
			})
			r, ok, err := updater.DetectLatest(context.Background(), RepositorySlug{owner: "owner", repo: "repo"})
			require.NotNil(t, r)
			assert.True(t, ok)
			assert.NoError(t, err)

			assert.Equal(t, testFixture.prerelease, r.Prerelease)
			assert.Equal(t, testFixture.version, r.Version())
		})
	}
}

func TestDetectReleasesForVariousArchives(t *testing.T) {
	for _, tc := range []struct {
		slug   string
		prefix string
	}{
		{"rhysd-test/test-release-zip", "v"},
		{"rhysd-test/test-release-tar", "v"},
		{"rhysd-test/test-release-gzip", "v"},
		{"rhysd-test/test-release-xz", "release-v"},
		{"rhysd-test/test-release-tar-xz", "release-"},
	} {
		t.Run(tc.slug, func(t *testing.T) {
			source, err := NewGitHubSource(GitHubConfig{})
			require.NoError(t, err, "failed to create source")
			updater, err := NewUpdater(Config{Source: source, Arch: "amd64"})
			require.NoError(t, err, "failed to create updater")
			r, ok, err := updater.DetectLatest(context.Background(), ParseSlug(tc.slug))
			skipRateLimitExceeded(t, err)

			assert.NoError(t, err, "fetch failed")
			assert.True(t, ok, "not found")
			require.NotNil(t, r, "release not detected")
			assert.Truef(t, r.Equal("1.2.3"), "incorrect release: expected 1.2.3 but got %v", r.Version())

			url := fmt.Sprintf("https://github.com/%s/releases/tag/%s1.2.3", tc.slug, tc.prefix)
			assert.Equal(t, url, r.URL)
			assert.NotEmpty(t, r.ReleaseNotes, "Release note is unexpectedly empty")

			if !strings.HasPrefix(r.AssetURL, fmt.Sprintf("https://github.com/%s/releases/download/%s1.2.3/", tc.slug, tc.prefix)) {
				t.Error("Unexpected asset URL:", r.AssetURL)
			}

			assert.NotEmpty(t, r.Name, "Release name is unexpectedly empty")
			assert.NotEmpty(t, r.AssetByteSize, "Asset's size is unexpectedly zero")
			assert.NotEmpty(t, r.AssetID, "Asset's ID is unexpectedly zero")
			assert.NotZero(t, r.PublishedAt)
		})
	}
}

func TestDetectReleaseButNoAsset(t *testing.T) {
	testData := []struct {
		run     bool
		name    string
		updater *Updater
	}{
		{true, "Mock", newMockUpdater(t, Config{Source: NewMockSource(
			[]SourceRelease{
				&GitHubRelease{
					name:    "first",
					tagName: "v1.0",
					assets:  nil,
				},
				&GitHubRelease{
					name:    "second",
					tagName: "v2.0",
					assets:  nil,
				},
			},
			nil,
		)})},
		{!testing.Short(), "GitHub", DefaultUpdater()},
	}

	for _, testItem := range testData {
		if !testItem.run {
			continue
		}
		t.Run(testItem.name, func(t *testing.T) {
			_, ok, err := testItem.updater.DetectLatest(context.Background(), ParseSlug("rhysd/clever-f.vim"))
			skipRateLimitExceeded(t, err)
			require.NoError(t, err)
			assert.False(t, ok, "When no asset found, result should be marked as 'not found'")
		})
	}
}

func TestNonExistingRepo(t *testing.T) {
	testData := []struct {
		run     bool
		name    string
		updater *Updater
	}{
		{true, "Mock", newMockUpdater(t, Config{Source: NewMockSource(nil, nil)})},
		{!testing.Short(), "GitHub", DefaultUpdater()},
	}

	for _, testItem := range testData {
		if !testItem.run {
			continue
		}
		t.Run(testItem.name, func(t *testing.T) {
			_, ok, err := testItem.updater.DetectLatest(context.Background(), ParseSlug("rhysd/non-existing-repo"))
			skipRateLimitExceeded(t, err)
			require.NoError(t, err)
			assert.False(t, ok, "Release for non-existing repo should not be found")
		})
	}
}

func TestNoReleaseFound(t *testing.T) {
	testData := []struct {
		run     bool
		name    string
		updater *Updater
	}{
		{true, "Mock", newMockUpdater(t, Config{Source: NewMockSource(nil, nil)})},
		{!testing.Short(), "GitHub", DefaultUpdater()},
	}

	for _, testItem := range testData {
		if !testItem.run {
			continue
		}
		t.Run(testItem.name, func(t *testing.T) {
			_, ok, err := testItem.updater.DetectLatest(context.Background(), ParseSlug("rhysd/misc"))
			skipRateLimitExceeded(t, err)
			require.NoError(t, err)
			assert.False(t, ok, "Repo having no release should not be found")
		})
	}
}

func TestFindAssetFromRelease(t *testing.T) {
	type findReleaseAndAssetFixture struct {
		name            string
		config          Config
		release         SourceRelease
		targetVersion   string
		expectedAsset   string
		expectedVersion string
		expectedFound   bool
	}

	rel1 := "rel1"
	v1 := "1.0.0"
	rel11 := "rel11"
	v11 := "1.1.0"
	asset1 := "asset1.gz"
	asset2 := "asset2.gz"
	wrongAsset1 := "asset1.yaml"
	asset11 := "asset11.gz"
	url1 := "https://asset1"
	url2 := "https://asset2"
	url11 := "https://asset11"

	testData := []findReleaseAndAssetFixture{
		{
			name:          "empty fixture",
			config:        Config{},
			release:       nil,
			targetVersion: "",
			expectedFound: false,
		},
		{
			name: "find asset, no filters",
			release: &GitHubRelease{
				name:    rel1,
				tagName: v1,
				assets: []SourceAsset{
					&GitHubAsset{name: asset1, url: url1},
				},
			},
			targetVersion:   "1.0.0",
			expectedAsset:   asset1,
			expectedVersion: "1.0.0",
			expectedFound:   true,
		},
		{
			name: "find asset, no target version",
			release: &GitHubRelease{
				name:    rel1,
				tagName: v1,
				assets: []SourceAsset{
					&GitHubAsset{name: asset1, url: url1},
				},
			},
			targetVersion:   "",
			expectedAsset:   asset1,
			expectedVersion: "1.0.0",
			expectedFound:   true,
		},
		{
			name: "don't find prerelease",
			release: &GitHubRelease{
				name:    rel1,
				tagName: v1,
				assets: []SourceAsset{
					&GitHubAsset{name: asset1, url: url1},
				},
				prerelease: true,
			},
			targetVersion:   "",
			expectedAsset:   asset1,
			expectedVersion: "1.0.0",
			expectedFound:   false,
		},
		{
			name: "find named prerelease",
			release: &GitHubRelease{
				name:    rel1,
				tagName: v1,
				assets: []SourceAsset{
					&GitHubAsset{name: asset1, url: url1},
				},
				prerelease: true,
			},
			targetVersion:   "1.0.0",
			expectedAsset:   asset1,
			expectedVersion: "1.0.0",
			expectedFound:   true,
		},
		{
			name:   "find prerelease",
			config: Config{Prerelease: true},
			release: &GitHubRelease{
				name:    rel1,
				tagName: v1,
				assets: []SourceAsset{
					&GitHubAsset{name: asset1, url: url1},
				},
				prerelease: true,
			},
			targetVersion:   "",
			expectedAsset:   asset1,
			expectedVersion: "1.0.0",
			expectedFound:   true,
		},
		{
			name: "don't find asset with wrong extension, no filters",
			release: &GitHubRelease{
				name:    rel11,
				tagName: v11,
				assets: []SourceAsset{
					&GitHubAsset{name: wrongAsset1, url: url11},
				},
			},
			targetVersion: "1.1.0",
			expectedFound: false,
		},
		{
			name: "find asset with different name, no filters",
			release: &GitHubRelease{
				name:    rel11,
				tagName: v11,
				assets: []SourceAsset{
					&GitHubAsset{name: asset1, url: url11},
				},
			},
			targetVersion:   "1.1.0",
			expectedAsset:   asset1,
			expectedVersion: "1.1.0",
			expectedFound:   true,
		},
		{
			name: "find asset, no filters (2)",
			release: &GitHubRelease{
				name:    rel11,
				tagName: v11,
				assets: []SourceAsset{
					&GitHubAsset{name: asset11, url: url11},
				},
			},
			targetVersion:   "1.1.0",
			expectedAsset:   asset11,
			expectedVersion: "1.1.0",
			expectedFound:   true,
		},
		{
			name: "find asset, match filter",
			release: &GitHubRelease{
				name:    rel11,
				tagName: v11,
				assets: []SourceAsset{
					&GitHubAsset{name: asset11, url: url11},
					&GitHubAsset{name: asset1, url: url1},
				},
			},
			targetVersion:   "1.1.0",
			config:          Config{Filters: []string{"11"}},
			expectedAsset:   asset11,
			expectedVersion: "1.1.0",
			expectedFound:   true,
		},
		{
			name: "find asset, match another filter",
			release: &GitHubRelease{
				name:    rel11,
				tagName: v11,
				assets: []SourceAsset{
					&GitHubAsset{name: asset11, url: url11},
					&GitHubAsset{name: asset1, url: url1},
				},
			},
			targetVersion:   "1.1.0",
			config:          Config{Filters: []string{"([^1])1{1}([^1])"}},
			expectedAsset:   asset1,
			expectedVersion: "1.1.0",
			expectedFound:   true,
		},
		{
			name: "find asset, match any filter",
			release: &GitHubRelease{
				name:    rel11,
				tagName: v11,
				assets: []SourceAsset{
					&GitHubAsset{name: asset11, url: url11},
					&GitHubAsset{name: asset2, url: url2},
				},
			},
			targetVersion:   "1.1.0",
			config:          Config{Filters: []string{"([^1])1{1}([^1])", "([^1])2{1}([^1])"}},
			expectedAsset:   asset2,
			expectedVersion: "1.1.0",
			expectedFound:   true,
		},
		{
			name: "find asset, match no filter",
			release: &GitHubRelease{
				name:    rel11,
				tagName: v11,
				assets: []SourceAsset{
					&GitHubAsset{name: asset11, url: url11},
					&GitHubAsset{name: asset2, url: url2},
				},
			},
			targetVersion: "",
			config:        Config{Filters: []string{"another", "binary"}},
			expectedFound: false,
		},
	}

	for _, fixture := range testData {
		t.Run(fixture.name, func(t *testing.T) {
			updater := newMockUpdater(t, fixture.config)
			asset, ver, found := updater.findAssetFromRelease(fixture.release, []string{".gz"}, fixture.targetVersion)
			if fixture.expectedFound {
				if !found {
					t.Fatalf("expected to find an asset for this fixture: %q", fixture.name)
				}
				if asset.GetName() == "" {
					t.Fatalf("invalid asset struct returned from fixture: %q, got: %v", fixture.name, asset)
				}
				if asset.GetName() != fixture.expectedAsset {
					t.Fatalf("expected asset %q in fixture: %q, got: %s", fixture.expectedAsset, fixture.name, asset.GetName())
				}
				t.Logf("asset %v, %v", asset, ver)
			} else if found {
				t.Fatalf("expected not to find an asset for this fixture: %q, but got: %v", fixture.name, asset)
			}
		})
	}
}

func TestFindReleaseAndAsset(t *testing.T) {
	SetLogger(stdlog.New(os.Stderr, "", 0))
	defer SetLogger(&emptyLogger{})

	tag2 := "v2.0.0"
	rel2 := "rel2"
	assetLinux386 := "asset_linux_386.tgz"
	assetLinuxAMD64 := "asset_linux_amd64.tgz"
	assetLinuxX86 := "asset_linux_x86_64.tgz"
	assetLinuxARM := "asset_linux_arm.tgz"
	assetLinuxARMv5 := "asset_linux_armv5.tgz"
	assetLinuxARMv6 := "asset_linux_armv6.tgz"
	assetLinuxARMv7 := "asset_linux_armv7.tgz"
	assetLinuxARM64 := "asset_linux_arm64.tgz"
	assetLinuxAll := "asset_linux_all.tgz"
	assetDarwinAMD64 := "asset_darwin_amd64.tgz"
	assetDarwinARM64 := "asset_darwin_arm64.tgz"
	assetDarwinAll := "asset_darwin_all.tgz"

	testData := []struct {
		name              string
		os                string
		arch              string
		arm               uint8
		universalArch     string
		releases          []SourceRelease
		version           string
		filters           []string
		found             bool
		expectedAssetName string
	}{
		{
			name: "no match",
			os:   "darwin",
			arch: "amd64",
			releases: []SourceRelease{
				&GitHubRelease{
					name:    rel2,
					tagName: tag2,
					assets: []SourceAsset{
						&GitHubAsset{
							name: assetLinux386,
						},
						&GitHubAsset{
							name: assetLinuxAMD64,
						},
					},
				},
			},
			version:           "v2.0.0",
			filters:           nil,
			found:             false,
			expectedAssetName: assetLinuxAMD64,
		},
		{
			name: "simple match",
			os:   "linux",
			arch: "amd64",
			releases: []SourceRelease{
				&GitHubRelease{
					name:    rel2,
					tagName: tag2,
					assets: []SourceAsset{
						&GitHubAsset{
							name: assetLinux386,
						},
						&GitHubAsset{
							name: assetLinuxAMD64,
						},
					},
				},
			},
			version:           "v2.0.0",
			filters:           nil,
			found:             true,
			expectedAssetName: assetLinuxAMD64,
		},
		{
			name: "simple match case insensitive",
			os:   "linux",
			arch: "amd64",
			releases: []SourceRelease{
				&GitHubRelease{
					name:    rel2,
					tagName: tag2,
					assets: []SourceAsset{
						&GitHubAsset{
							name: assetLinux386,
						},
						&GitHubAsset{
							name: "asset_Linux_AMD64.tgz",
						},
					},
				},
			},
			version:           "v2.0.0",
			filters:           nil,
			found:             true,
			expectedAssetName: "asset_Linux_AMD64.tgz",
		},
		{
			name: "match default arm",
			os:   "linux",
			arch: "arm",
			releases: []SourceRelease{
				&GitHubRelease{
					name:    rel2,
					tagName: tag2,
					assets: []SourceAsset{
						&GitHubAsset{
							name: assetLinuxARM,
						},
						&GitHubAsset{
							name: assetLinuxARM64,
						},
						&GitHubAsset{
							name: assetLinuxARMv5,
						},
						&GitHubAsset{
							name: assetLinuxARMv6,
						},
						&GitHubAsset{
							name: assetLinuxARMv7,
						},
					},
				},
			},
			version:           "v2.0.0",
			filters:           nil,
			found:             true,
			expectedAssetName: assetLinuxARM,
		},
		{
			name: "match armv6",
			os:   "linux",
			arch: "arm",
			arm:  6,
			releases: []SourceRelease{
				&GitHubRelease{
					name:    rel2,
					tagName: tag2,
					assets: []SourceAsset{
						&GitHubAsset{
							name: assetLinuxARM,
						},
						&GitHubAsset{
							name: assetLinuxARM64,
						},
						&GitHubAsset{
							name: assetLinuxARMv5,
						},
						&GitHubAsset{
							name: assetLinuxARMv6,
						},
						&GitHubAsset{
							name: assetLinuxARMv7,
						},
					},
				},
			},
			version:           "v2.0.0",
			filters:           nil,
			found:             true,
			expectedAssetName: assetLinuxARMv6,
		},
		{
			name: "fallback to armv5",
			os:   "linux",
			arch: "arm",
			arm:  7,
			releases: []SourceRelease{
				&GitHubRelease{
					name:    rel2,
					tagName: tag2,
					assets: []SourceAsset{
						&GitHubAsset{
							name: assetLinuxARM,
						},
						&GitHubAsset{
							name: assetLinuxARM64,
						},
						&GitHubAsset{
							name: assetLinuxARMv5,
						},
					},
				},
			},
			version:           "v2.0.0",
			filters:           nil,
			found:             true,
			expectedAssetName: assetLinuxARMv5,
		},
		{
			name: "fallback to arm",
			os:   "linux",
			arch: "arm",
			arm:  5,
			releases: []SourceRelease{
				&GitHubRelease{
					name:    rel2,
					tagName: tag2,
					assets: []SourceAsset{
						&GitHubAsset{
							name: assetLinuxARM,
						},
						&GitHubAsset{
							name: assetLinuxARM64,
						},
					},
				},
			},
			version:           "v2.0.0",
			filters:           nil,
			found:             true,
			expectedAssetName: assetLinuxARM,
		},
		{
			name: "arm not found",
			os:   "linux",
			arch: "arm",
			arm:  6,
			releases: []SourceRelease{
				&GitHubRelease{
					name:    rel2,
					tagName: tag2,
					assets: []SourceAsset{
						&GitHubAsset{
							name: assetLinuxARMv7,
						},
						&GitHubAsset{
							name: assetLinuxARM64,
						},
					},
				},
			},
			version:           "v2.0.0",
			filters:           nil,
			found:             false,
			expectedAssetName: assetLinuxARM,
		},
		{
			name: "match x86_64 for adm64",
			os:   "linux",
			arch: "amd64",
			releases: []SourceRelease{
				&GitHubRelease{
					name:    rel2,
					tagName: tag2,
					assets: []SourceAsset{
						&GitHubAsset{
							name: assetLinux386,
						},
						&GitHubAsset{
							name: assetLinuxX86,
						},
					},
				},
			},
			version:           "v2.0.0",
			filters:           nil,
			found:             true,
			expectedAssetName: assetLinuxX86,
		},
		{
			name:          "universal binary ignored on linux",
			os:            "linux", // universal binary is for darwin only
			arch:          "amd64",
			universalArch: "all",
			releases: []SourceRelease{
				&GitHubRelease{
					name:    rel2,
					tagName: tag2,
					assets: []SourceAsset{
						&GitHubAsset{
							name: assetLinuxAll,
						},
					},
				},
			},
			version: "v2.0.0",
			filters: nil,
			found:   false,
		},
		{
			name:          "match amd64 instead of universal binary",
			os:            "darwin", // universal binary is for darwin only
			arch:          "amd64",
			universalArch: "all",
			releases: []SourceRelease{
				&GitHubRelease{
					name:    rel2,
					tagName: tag2,
					assets: []SourceAsset{
						&GitHubAsset{
							name: assetDarwinAMD64,
						},
						&GitHubAsset{
							name: assetDarwinARM64,
						},
						&GitHubAsset{
							name: assetDarwinAll,
						},
					},
				},
			},
			version:           "v2.0.0",
			filters:           nil,
			found:             true,
			expectedAssetName: assetDarwinAMD64,
		},
		{
			name:          "match arm64 instead of universal binary",
			os:            "darwin", // universal binary is for darwin only
			arch:          "arm64",
			universalArch: "all",
			releases: []SourceRelease{
				&GitHubRelease{
					name:    rel2,
					tagName: tag2,
					assets: []SourceAsset{
						&GitHubAsset{
							name: assetDarwinAMD64,
						},
						&GitHubAsset{
							name: assetDarwinARM64,
						},
						&GitHubAsset{
							name: assetDarwinAll,
						},
					},
				},
			},
			version:           "v2.0.0",
			filters:           nil,
			found:             true,
			expectedAssetName: assetDarwinARM64,
		},
		{
			name:          "match universal binary",
			os:            "darwin", // universal binary is for darwin only
			arch:          "arm64",
			universalArch: "all",
			releases: []SourceRelease{
				&GitHubRelease{
					name:    rel2,
					tagName: tag2,
					assets: []SourceAsset{
						&GitHubAsset{
							name: assetDarwinAll,
						},
					},
				},
			},
			version:           "v2.0.0",
			filters:           nil,
			found:             true,
			expectedAssetName: assetDarwinAll,
		},
		{
			name:          "no match when universal binary not specified",
			os:            "darwin",
			arch:          "arm64",
			universalArch: "",
			releases: []SourceRelease{
				&GitHubRelease{
					name:    rel2,
					tagName: tag2,
					assets: []SourceAsset{
						&GitHubAsset{
							name: assetDarwinAll,
						},
					},
				},
			},
			version: "v2.0.0",
			filters: nil,
			found:   false,
		},
	}

	for _, testItem := range testData {
		t.Run(testItem.name, func(t *testing.T) {
			t.Parallel()

			updater, err := NewUpdater(Config{
				Filters:       testItem.filters,
				OS:            testItem.os,
				Arch:          testItem.arch,
				Arm:           testItem.arm,
				UniversalArch: testItem.universalArch,
			})
			require.NoError(t, err)
			_, asset, _, found := updater.findReleaseAndAsset(testItem.releases, testItem.version)
			assert.Equal(t, testItem.found, found)
			if found {
				assert.Equal(t, testItem.expectedAssetName, asset.GetName())
			}
		})
	}
}

func TestBuildMultistepValidationChain(t *testing.T) {
	testVersion := "v0.14.0"
	source, keyRing := mockPGPSourceRepository(t)
	checksumValidator := &ChecksumValidator{UniqueFilename: "checksums.txt"}

	t.Run("ValidConfig", func(t *testing.T) {
		updater, _ := NewUpdater(Config{
			Source:    source,
			Validator: NewChecksumWithPGPValidator("checksums.txt", keyRing),
		})

		release, found, err := updater.DetectVersion(context.Background(), testGithubRepository, testVersion)
		require.True(t, found)
		assert.NoError(t, err)
		assert.Equal(t, 2, len(release.ValidationChain))
		assert.Equal(t, "checksums.txt", release.ValidationChain[0].ValidationAssetName)
		assert.Equal(t, "checksums.txt.asc", release.ValidationChain[1].ValidationAssetName)
	})

	t.Run("LoopConfig", func(t *testing.T) {
		updater, _ := NewUpdater(Config{
			Source: source,
			Validator: new(PatternValidator).
				Add("*", checksumValidator),
		})

		_, _, err := updater.DetectVersion(context.Background(), testGithubRepository, testVersion)
		assert.NoError(t, err)
	})

	t.Run("InvalidLoopConfig", func(t *testing.T) {
		updater, _ := NewUpdater(Config{
			Source: source,
			Validator: new(PatternValidator).
				Add("*.*z*", checksumValidator).
				Add("*", new(SHAValidator)),
		})

		_, _, err := updater.DetectVersion(context.Background(), testGithubRepository, testVersion)
		assert.EqualError(t, err, "validation file not found: \"checksums.txt.sha256\"")
	})
}

func newMockUpdater(t *testing.T, config Config) *Updater {
	t.Helper()

	if config.Source == nil {
		config.Source = mockSourceRepository(t)
	}
	updater, err := NewUpdater(config)
	require.NoError(t, err)
	return updater
}